Convert @bugsnag/core/lib/callback-runner to TypeScript#2438
Merged
gingerbenw merged 13 commits intointegration/typescriptfrom Jul 7, 2025
Merged
Convert @bugsnag/core/lib/callback-runner to TypeScript#2438gingerbenw merged 13 commits intointegration/typescriptfrom
gingerbenw merged 13 commits intointegration/typescriptfrom
Conversation
| type NodeCallbackType<T = any> = (error?: Error | null, result?: T) => void; | ||
|
|
||
| const runCallbacks = <T>( | ||
| callbacks: any[], |
Contributor
Author
There was a problem hiding this comment.
Wanted to specify the type here based on usage of this function.
Suggested change
| callbacks: any[], | |
| callbacks: (OnErrorCallback | undefined)[], |
But got errors from callback-runner.test as we are using other types there. I'm assuming that we expecting any type of callbacks.
Member
There was a problem hiding this comment.
I think this is okay to be any here - we don't necessarily know that what we're providing is even a function and we're handling it when it's not - happy to leave it 👍🏻
gingerbenw
force-pushed
the
PLAT-13697-callback-runner
branch
2 times, most recently
from
4d10b2e to
1ffb4a4
Compare
gingerbenw
force-pushed
the
PLAT-13697-callback-runner
branch
from
d8b5e70 to
8ef69af
Compare
gingerbenw
previously approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Convert @bugsnag/core/lib/callback-runner to TypeScript
Testing
Covered by existing end to end and unit tests