Merge branch 'integration/typescript' into PLAT-13697-callback-runner

Author: gingerbenw

packages/core/src/config.ts

@@ -1,4 +1,3 @@
-import isArray from './lib/es-utils/is-array'
 import includes from './lib/es-utils/includes'
 import intRange from './lib/validators/int-range'
 import stringWithLength from './lib/validators/string-with-length'
@@ -210,7 +209,7 @@ const schema: Schema = {
   enabledReleaseStages: {
     defaultValue: () => null,
     message: 'should be an array of strings',
-    validate: (value: unknown) => value === null || (isArray(value) && value.filter(f => typeof f === 'string').length === value.length)
+    validate: (value: unknown) => value === null || (Array.isArray(value) && value.filter(f => typeof f === 'string').length === value.length)
   },
   releaseStage: {
     defaultValue: () => 'production',
@@ -225,7 +224,7 @@ const schema: Schema = {
   enabledBreadcrumbTypes: {
     defaultValue: () => BREADCRUMB_TYPES,
     message: `should be null or a list of available breadcrumb types (${BREADCRUMB_TYPES.join(',')})`,
-    validate: (value: unknown) => value === null || (isArray(value) && value.reduce((accum, maybeType) => {
+    validate: (value: unknown) => value === null || (Array.isArray(value) && value.reduce((accum, maybeType) => {
       if (accum === false) return accum
       // TS doesn't like passing a readonly to a function that might mutate an array
       return includes(BREADCRUMB_TYPES as unknown as any[], maybeType)
@@ -266,23 +265,23 @@ const schema: Schema = {
     defaultValue: () => ['password'],
     message: 'should be an array of strings|regexes',
     validate: (value: unknown) =>
-      isArray(value) && value.length === value.filter(s =>
+      Array.isArray(value) && value.length === value.filter(s =>
         (typeof s === 'string' || (s && typeof s.test === 'function'))
       ).length
   },
   plugins: {
     defaultValue: () => ([]),
     message: 'should be an array of plugin objects',
     validate: (value: unknown) =>
-      isArray(value) && value.length === value.filter(p =>
+      Array.isArray(value) && value.length === value.filter(p =>
         (p && typeof p === 'object' && typeof p.load === 'function')
       ).length
   },
   featureFlags: {
     defaultValue: () => [],
     message: 'should be an array of objects that have a "name" property',
     validate: (value: unknown) =>
-      isArray(value) && value.length === value.filter(feature =>
+      Array.isArray(value) && value.length === value.filter(feature =>
         feature && typeof feature === 'object' && typeof feature.name === 'string'
       ).length
   },

packages/core/src/lib/derecursify.js

@@ -1,5 +1,3 @@
-const isArray = require('./es-utils/is-array')
-
 const isSafeLiteral = (obj) => (
   typeof obj === 'string' || obj instanceof String ||
   typeof obj === 'number' || obj instanceof Number ||
@@ -53,7 +51,7 @@ module.exports = function (data) {
     }
 
     // handle arrays, and all iterable non-array types (such as Set)
-    if (isArray(obj) || obj[Symbol.iterator]) {
+    if (Array.isArray(obj) || obj[Symbol.iterator]) {
       seen.push(obj)
       const safeArray = []
       try {

packages/core/src/lib/es-utils/is-array.d.ts

@@ -1,6 +1,5 @@
-import isArray from './es-utils/is-array'
 import jsonStringify from '@bugsnag/safe-json-stringify'
-import {FeatureFlag} from "../common";
+import type { FeatureFlag } from "../common";
 
 type FeatureFlagEventApi = {
   featureFlag: string
@@ -41,7 +40,7 @@ const featureFlagDelegate: FeatureFlagDelegate = {
   },
 
   merge: (existingFeatures, newFeatures, existingFeatureKeys) => {
-    if (!isArray(newFeatures)) {
+    if (!Array.isArray(newFeatures)) {
       return
     }
 

packages/core/src/lib/es-utils/is-array.js

@@ -1,5 +1,3 @@
-import isArray from '../es-utils/is-array'
-
-const listOfFunctions = (value: unknown): boolean => typeof value === 'function' || (isArray(value) && value.filter(f => typeof f === 'function').length === value.length)
+const listOfFunctions = (value: unknown): boolean => typeof value === 'function' || (Array.isArray(value) && value.filter(f => typeof f === 'function').length === value.length)
 
 export default listOfFunctions

packages/core/src/lib/feature-flag-delegate.ts

@@ -1,17 +1,6 @@
-import isArray from '../../src/lib/es-utils/is-array'
 import includes from '../../src/lib/es-utils/includes'
 
 describe('es-utils', () => {
-  describe('isArray(obj)', () => {
-    it('works with a variety of examples', () => {
-      expect(isArray([])).toBe(true)
-      expect(isArray('[object Array]')).toBe(false)
-      expect(isArray(0)).toBe(false)
-      expect(isArray(1)).toBe(false)
-      expect(isArray({})).toBe(false)
-    })
-  })
-
   describe('includes(arr, item)', () => {
     it('works with a variety of examples', () => {
       expect(includes(['a', 'b', 'c'], 'a')).toBe(true)