Skip to content

Enable unreachable code checks in tui/ with mypy #3518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svartkanin merged 1 commit into from
May 28, 2025
Merged

Enable unreachable code checks in tui/ with mypy #3518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions archinstall/tui/curses_menu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,9 +637,6 @@ def _process_edit_key(self, key: int) -> int | None:
self._show_help()
return None
case MenuKeys.ESC:
if self._help_active:
Copy link
Copy Markdown
Contributor Author

@correctmost correctmost May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is already performed on line 619

self._help_active = False
self._draw()
if self._allow_skip:
self._last_state = Result(ResultType.Skip, None)
key = 7
Expand Down Expand Up @@ -744,7 +741,7 @@ def __init__(
self._init_viewports(preview_size)

assert self._menu_vp is not None
self._items_state: MenuItemsState = MenuItemsState(
self._items_state: MenuItemsState = MenuItemsState( # type: ignore[unreachable]
Copy link
Copy Markdown
Contributor Author

@correctmost correctmost May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a false positive from mypy:
python/mypy#11969

self._item_group,
total_cols=self._horizontal_cols,
total_rows=self._menu_vp.height,
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ disallow_any_explicit = true

[[tool.mypy.overrides]]
module = "archinstall.tui.*"
warn_unreachable = false

[[tool.mypy.overrides]]
module = [
Expand Down