Enable unreachable code checks in tui/ with mypy#3518
Merged
svartkanin merged 1 commit intoarchlinux:masterfrom May 28, 2025
Merged
Enable unreachable code checks in tui/ with mypy#3518svartkanin merged 1 commit intoarchlinux:masterfrom
svartkanin merged 1 commit intoarchlinux:masterfrom
Conversation
correctmost
commented
May 28, 2025
|
|
||
| assert self._menu_vp is not None | ||
| self._items_state: MenuItemsState = MenuItemsState( | ||
| self._items_state: MenuItemsState = MenuItemsState( # type: ignore[unreachable] |
Contributor
Author
There was a problem hiding this comment.
This is a false positive from mypy:
python/mypy#11969
| self._show_help() | ||
| return None | ||
| case MenuKeys.ESC: | ||
| if self._help_active: |
Contributor
Author
There was a problem hiding this comment.
This check is already performed on line 619
svartkanin
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
Enabling unreachable code checks can help find dead code and incorrect type annotations.
Tests and Checks