Merged
Conversation
Owner
|
Do you understand why the call give the segfault? |
Contributor
Author
Segfault is due to some implementation detail of the CXXGraph object. Has to be debug elsewhere; however this fix identifies the buggy tests and comment them out (which should be tracked elsewhere) and propose a fix to re-enable benchmarking tests. |
Owner
|
Ok, I open an issue about this |
ZigRazor
approved these changes
May 13, 2025
ai-mannamalai
force-pushed
the
ma-benchmark-fix
branch
from
0109dee to
a0d2f1d
Compare
Contributor
Author
|
fixing the code formatting issue - seems OK. @ZigRazor Any idea on how this Labeler failure can be resolved ? |
Owner
I can view this later.. useless workflow :) |
Contributor
Author
|
Also the clang-format fails in the include/ folder which is not touched in the commit
```
clang-format Check, Attempt #2 / Formatting Check (include/CXXGraph)
Failed in 25 seconds
```
From: ZigRazor ***@***.***>
Date: Tuesday, May 13, 2025 at 9:17 AM
To: ZigRazor/CXXGraph ***@***.***>
Cc: Muthu Annamalai ***@***.***>, Author ***@***.***>
Subject: [EXTERNAL] Re: [ZigRazor/CXXGraph] Fix benchmark suite (PR #503)
[Image removed by sender.]ZigRazor left a comment (ZigRazor/CXXGraph#503)<#503 (comment)>
fixing the code formatting issue - seems OK. @ZigRazor<https://github.com/ZigRazor> Any idea on how this Labeler failure can be resolved ?
Run ***@***.***
The configuration file (path: .github/labeler.yml) was not found locally, fetching via the api
Error: Error: found unexpected type for label 'repo' (should be array of config options)
Error: found unexpected type for label 'repo' (should be array of config options)
I can view this later.. useless workflow :)
—
Reply to this email directly, view it on GitHub<#503 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/APGLTDF7IPRMD4LA6EMNQEL26ILKNAVCNFSM6AAAAAB45D25VCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNZXGE3DKMZZHA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Contributor
Author
|
Why is the windows build failing on something unrelated to this PR ? |
Owner
|
The windows problem is the path of the test file, in any case this could be merged |
- clang-fmt fix - fix signed
ai-mannamalai
force-pushed
the
ma-benchmark-fix
branch
from
a0d2f1d to
291cb85
Compare
Contributor
Author
|
Signed the commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix benchmark suite and comment out tests causing segfaults