Segmentation fault while running benchmark_exe

[AryanGitHub]

Describe the bug
I am getting a Segmentation fault while running benchmark_exe.

To Reproduce
Steps to reproduce the behavior:

1. following the given steps at Benchmark Execution
2. run ./benchmark_exe

Expected behavior
the complete benchmark_exe should execute.

Screenshots

[user@fedora benchmark]$ ./benchmark_exe 
2023-09-26T22:54:46+05:30
Running ./benchmark_exe
Run on (8 X 4200 MHz CPU s)
CPU Caches:
  L1 Data 48 KiB (x4)
  L1 Instruction 32 KiB (x4)
  L2 Unified 1280 KiB (x4)
  L3 Unified 8192 KiB (x1)
Load Average: 0.93, 0.59, 0.45
***WARNING*** CPU scaling is enabled, the benchmark real time measurements may be noisy and will incur extra overhead.
***WARNING*** Library was built as DEBUG. Timings may be affected.
----------------------------------------------------------------------------------
Benchmark                                        Time             CPU   Iterations
----------------------------------------------------------------------------------
BFS_X/1                                       3698 ns         3693 ns       189718
BFS_X/18                                     29347 ns        29302 ns        24008
BFS_X/324                                   491839 ns       491235 ns         1401
BFS_X/5832                                 9127946 ns      9102094 ns           75
BFS_X/104976                             273177336 ns    272093218 ns            3
BFS_X/262144                             287219843 ns    286424086 ns            3
Segmentation fault (core dumped)

Desktop (please complete the following information):

• OS: Fedora Linux 38 (Workstation Edition) 64bit
• Version: 38

[ZigRazor]

@AryanGitHub can you execute it in debug mode? or provide us the coredump generated?

Thank you

[AryanGitHub]

• can you execute it in debug mode?

Yes, but I dont know how is benchmark is getting built as debug. I did not put the DEBUG flag, at the build.

• provide us the coredump generated?

The coredump is not displaying the source code.
It is 1.4GB, I have compressed it to 314 MB
https://file.io/BcLoaPTpI0AM

# extract files
tar -xaf archive_name.tar.gz -C path/to/directory

[ZigRazor]

Thank you, but could be more useful the stack of the coredump already opened.
With only the coredump we can't open it if the executable is not compiled in the same machine.

Thanks in advance

[ai-mannamalai]

I think it maybe related to memory overflow; my run on latest repo (SHAID : ) shows

./benchmark_exe
Unable to determine clock rate from sysctl: hw.cpufrequency: No such file or directory
This does not affect benchmark measurements, only the metadata output.
***WARNING*** Failed to set thread affinity. Estimated CPU frequency may be incorrect.
2025-05-11T22:28:40-07:00
Running ./benchmark_exe
Run on (12 X 24 MHz CPU s)
CPU Caches:
  L1 Data 64 KiB
  L1 Instruction 128 KiB
  L2 Unified 4096 KiB (x12)
Load Average: 2.10, 1.82, 1.48
***WARNING*** Library was built as DEBUG. Timings may be affected.
----------------------------------------------------------------------------------
Benchmark                                        Time             CPU   Iterations
----------------------------------------------------------------------------------
BFS_X/1                                       2486 ns         2481 ns       277752
BFS_X/18                                     11998 ns        11980 ns        62676
BFS_X/324                                   171975 ns       171948 ns         3928
BFS_X/5832                                 2882989 ns      2882905 ns          243
BFS_X/104976                            2.1760e+10 ns   2.1750e+10 ns            1
devel/CXXGraph/buildx/_deps/googlebenchmark-src/src/complexity.cc:171: ComputeBigO: Check `(run.complexity_n) > (0)' failed. Did you forget to call SetComplexityN?
zsh: abort      ./benchmark_exe
 benchmark % 

[ai-mannamalai]

Further I see a segfault in the Mac OS-X

FS_X_BigO                              7018969212.28 (1)  7018968406.47 (1)  
BFS_X_RMS                                      141 %           141 %    
Process 25294 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x10)
    frame #0: 0x0000000100025fe0 benchmark_exe`std::__1::shared_ptr<CXXGraph::Edge<int> const>::operator->[abi:ne180100](this=0x0000000000000010) const at shared_ptr.h:724:12
   721 
   722    _LIBCPP_HIDE_FROM_ABI element_type* operator->() const _NOEXCEPT {
   723      static_assert(!is_array<_Tp>::value, "std::shared_ptr<T>::operator-> is only valid when T is not an array type.");
-> 724      return __ptr_;
   725    }
   726 
   727    _LIBCPP_HIDE_FROM_ABI long use_count() const _NOEXCEPT { return __cntrl_ ? __cntrl_->use_count() : 0; }
Target 0: (benchmark_exe) stopped.
(lldb) up
frame #1: 0x0000000100005ee0 benchmark_exe`BFS_FromReadedCitHep(state=0x000000016fdfd580) at BFS_BM.cpp:30:11
   27     auto edgeSet = cit_graph_ptr->getEdgeSet();
   28     for (auto _ : state) {
   29       auto &result = cit_graph_ptr->breadth_first_search(
-> 30           *((*(edgeSet.begin()))->getNodePair().first));
   31     }
   32     state.SetComplexityN(2);
   33   }
(lldb) list
   34  
   35   BENCHMARK(BFS_FromReadedCitHep)->Complexity();
   36  
   37   static void PSEUDO_CONCURRENCY_BFS_X(benchmark::State &state) {
   38     CXXGraph::Graph<int> g;
   39     auto range_start = edges.begin();
   40     auto range_end = edges.find(state.range(0));
(lldb) q
Quitting LLDB will kill one or more processes. Do you really want to proceed: [Y/n] Y
mannamalai@core-mannamalai benchmark % cd .. 

[ZigRazor]

@ai-mannamalai it could be... obviously the benchmark with an high number of edge requires too much RAM.
Probably if you reduce the number of edge on becnhmark test should work.
Let me know, and thank you in advance.

[ai-mannamalai]

it is not related to RAM size on my experiments; the issues are related to the GXXGraph object

[ai-mannamalai]

@ZigRazor - this MR has the fix for benchmark and indicate the bugs comment out.