Skip to content

CCM-14616: file scanner, update the prefix#238

Merged
nhsd-angel-pastor merged 10 commits intomainfrom
feature/CCM-14616-fixes
Apr 2, 2026
Merged

CCM-14616: file scanner, update the prefix#238
nhsd-angel-pastor merged 10 commits intomainfrom
feature/CCM-14616-fixes

Conversation

@nhsd-angel-pastor
Copy link
Copy Markdown
Contributor

@nhsd-angel-pastor nhsd-angel-pastor commented Mar 12, 2026

Description

Code changes to integrate DL with Supplier API. Identified issues:

  • variant letter was incorrect, see https://nhsd-jira.digital.nhs.uk/browse/CCM-14326
  • subject from Supplier API was different than expected
    -- changed the validation of the incoming subject
    -- changed how DL builds the subject of the transitioned status
  • Imported newer library from Supplier API

Context

Findings under confluence page https://nhsd-confluence.digital.nhs.uk/spaces/RIS/pages/1327224829/Digital+Letters+-+E2E+Connectivity+test+WIP

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • If I have used the 'skip-trivy-package' label I have done so responsibly and in the knowledge that this is being fixed as part of a separate ticket/PR.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@nhsd-angel-pastor nhsd-angel-pastor force-pushed the feature/CCM-14616-fixes branch 2 times, most recently from 54ff79e to 0eaa32d Compare March 16, 2026 14:48
@nhsd-angel-pastor nhsd-angel-pastor force-pushed the feature/CCM-14616-fixes branch 3 times, most recently from 559e918 to 46fe37e Compare March 23, 2026 09:41
@simonlabarere simonlabarere force-pushed the feature/CCM-14616-fixes branch from 30fe071 to 46fe37e Compare March 23, 2026 13:43
@nhsd-angel-pastor nhsd-angel-pastor force-pushed the feature/CCM-14616-fixes branch 6 times, most recently from 1d4c3c0 to fb623ce Compare March 31, 2026 09:21
@nhsd-angel-pastor nhsd-angel-pastor force-pushed the feature/CCM-14616-fixes branch from 03ffa28 to dab8692 Compare April 1, 2026 09:05
Comment thread lambdas/print-status-handler/src/apis/sqs-handler.ts
Comment thread lambdas/print-status-handler/package.json
Comment thread lambdas/print-sender-lambda/src/__tests__/app/print-sender.test.ts
Comment thread lambdas/print-status-handler/src/apis/sqs-handler.ts Outdated
@nhsd-angel-pastor nhsd-angel-pastor marked this pull request as ready for review April 1, 2026 09:24
@nhsd-angel-pastor nhsd-angel-pastor requested a review from a team as a code owner April 1, 2026 09:24
Comment thread lambdas/print-status-handler/src/apis/sqs-handler.ts
simonlabarere
simonlabarere previously approved these changes Apr 1, 2026
@gareth-allan gareth-allan self-assigned this Apr 2, 2026
Comment thread lambdas/print-status-handler/src/apis/sqs-handler.ts Outdated
Comment thread lambdas/print-status-handler/src/__tests__/test-data.ts Outdated
@nhsd-angel-pastor nhsd-angel-pastor merged commit 85ce2d3 into main Apr 2, 2026
115 of 118 checks passed
@nhsd-angel-pastor nhsd-angel-pastor deleted the feature/CCM-14616-fixes branch April 2, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants