CCM-14616: file scanner, update the prefix#238
Merged
nhsd-angel-pastor merged 10 commits intomainfrom Apr 2, 2026
Merged
Conversation
54ff79e to
0eaa32d
Compare
559e918 to
46fe37e
Compare
30fe071 to
46fe37e
Compare
1d4c3c0 to
fb623ce
Compare
03ffa28 to
dab8692
Compare
simonlabarere
previously approved these changes
Apr 1, 2026
gareth-allan
reviewed
Apr 2, 2026
dab8692 to
e3fae42
Compare
gareth-allan
approved these changes
Apr 2, 2026
simonlabarere
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Code changes to integrate DL with Supplier API. Identified issues:
-- changed the validation of the incoming subject
-- changed how DL builds the subject of the transitioned status
Context
Findings under confluence page https://nhsd-confluence.digital.nhs.uk/spaces/RIS/pages/1327224829/Digital+Letters+-+E2E+Connectivity+test+WIP
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.