CCM-14616: Address review comments

Author: nhsd-angel-pastor

lambdas/print-status-handler/src/__tests__/test-data.ts

@@ -9,8 +9,8 @@ export const acceptedLetterEvent = {
     'letter-origin/digital-letters/letter/f47ac10b-58cc-4372-a567-0e02b2c3d479_2503cbd5-6722-4e90-9fbd-5f1e96d65c22',
   type: 'uk.nhs.notify.supplier-api.letter.ACCEPTED.v1',
   dataschema:
-    'https://notify.nhs.uk/cloudevents/schemas/supplier-api/letter.ACCEPTED.1.0.16.schema.json',
-  dataschemaversion: '1.0.16',
+    'https://notify.nhs.uk/cloudevents/schemas/supplier-api/letter.ACCEPTED.1.0.17.schema.json',
+  dataschemaversion: '1.0.17',
   time: '2023-06-20T12:00:00Z',
   recordedtime: '2023-06-20T12:00:00.250Z',
   severitynumber: 2,
@@ -44,8 +44,8 @@ export const failedLetterEvent = {
     'letter-origin/digital-letters/letter/f47ac10b-58cc-4372-a567-0e02b2c3d480_2503cbd5-6722-4e90-9fbd-5f1e96d65c22',
   type: 'uk.nhs.notify.supplier-api.letter.FAILED.v1',
   dataschema:
-    'https://notify.nhs.uk/cloudevents/schemas/supplier-api/letter.FAILED.1.0.16.schema.json',
-  dataschemaversion: '1.0.16',
+    'https://notify.nhs.uk/cloudevents/schemas/supplier-api/letter.FAILED.1.0.17.schema.json',
+  dataschemaversion: '1.0.17',
   time: '2023-06-20T13:00:00Z',
   recordedtime: '2023-06-20T13:00:00.250Z',
   severitynumber: 3,

lambdas/print-status-handler/src/apis/sqs-handler.ts

@@ -68,9 +68,11 @@ function validateRecord(
       return null;
     }
 
-    logger.info(
-      `Successfully validated SQS record with messageId: ${messageId}, subject: ${item.data.origin.subject}`,
-    );
+    logger.info({
+      description: 'Successfully validated SQS record',
+      messageId,
+      subject: item.data.origin.subject,
+    });
 
     return { messageId, event: item };
   } catch (error) {

tests/playwright/digital-letters-component-tests/print-status-handler.component.spec.ts

@@ -15,7 +15,7 @@ const baseLetterEvent = {
   id: '550e8400-e29b-41d4-a716-446655440001',
   specversion: '1.0',
   source: '/data-plane/supplier-api/prod/update-status',
-  dataschemaversion: '1.0.16',
+  dataschemaversion: '1.0.17',
   time: '2023-06-20T12:00:00Z',
   recordedtime: '2023-06-20T12:00:00.250Z',
   severitynumber: 2,
@@ -65,7 +65,7 @@ test.describe('Print status handler', () => {
         ...baseLetterEvent,
         subject: `letter-origin/letter-rendering/letter/00f3b388-bbe9-41c9-9e76-052d37ee8988_${messageReference}`,
         type: `uk.nhs.notify.supplier-api.letter.${status}.v1`,
-        dataschema: `https://notify.nhs.uk/cloudevents/schemas/supplier-api/letter.${status}.1.0.16.schema.json`,
+        dataschema: `https://notify.nhs.uk/cloudevents/schemas/supplier-api/letter.${status}.1.0.17.schema.json`,
         data: {
           ...baseLetterEvent.data,
           status,