Skip to content

Commit d0a09d9

Browse files
CCM-14616: remove redundant code
1 parent fab7306 commit d0a09d9

2 files changed

Lines changed: 0 additions & 77 deletions

File tree

lambdas/print-status-handler/src/__tests__/apis/sqs-handler.test.ts

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import { EventPublisher, Logger } from 'utils';
55
import {
66
acceptedLetterEvent,
77
failedLetterEvent,
8-
pendingLetterEvent,
98
recordEvent,
109
} from '__tests__/test-data';
1110

@@ -33,45 +32,6 @@ describe('SQS Handler', () => {
3332

3433
describe('letter status transitions', () => {
3534
it('should send print.letter.transitioned event when letter.ACCEPTED received', async () => {
36-
const response = await handler(recordEvent([pendingLetterEvent]));
37-
38-
expect(eventPublisher.sendEvents).toHaveBeenCalledWith(
39-
[
40-
{
41-
...pendingLetterEvent,
42-
id: '550e8400-e29b-41d4-a716-446655440001',
43-
time: '2023-06-20T12:00:00.250Z',
44-
recordedtime: '2023-06-20T12:00:00.250Z',
45-
dataschema:
46-
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-print-letter-transitioned-data.schema.json',
47-
type: 'uk.nhs.notify.digital.letters.print.letter.transitioned.v1',
48-
source:
49-
'/nhs/england/notify/production/primary/data-plane/digitalletters/print',
50-
subject:
51-
'client/32124dde-4b36-4a49-8686-e9da9cbff725/letter-request/2503cbd5-6722-4e90-9fbd-5f1e96d65c22',
52-
data: {
53-
senderId: pendingLetterEvent.data.origin.subject.split('/')[1],
54-
messageReference:
55-
pendingLetterEvent.data.origin.subject.split('/')[3],
56-
specificationId: pendingLetterEvent.data.specificationId,
57-
status: pendingLetterEvent.data.status,
58-
supplierId: pendingLetterEvent.data.supplierId,
59-
time: pendingLetterEvent.time,
60-
},
61-
},
62-
],
63-
expect.any(Function),
64-
);
65-
expect(logger.info).toHaveBeenCalledWith(
66-
'Received SQS Event of 1 record(s)',
67-
);
68-
expect(logger.info).toHaveBeenCalledWith(
69-
'1 of 1 records processed successfully',
70-
);
71-
expect(response).toEqual({ batchItemFailures: [] });
72-
});
73-
74-
it('should send print.letter.transitioned event when letter.PENDING received', async () => {
7535
const response = await handler(recordEvent([acceptedLetterEvent]));
7636

7737
expect(eventPublisher.sendEvents).toHaveBeenCalledWith(

lambdas/print-status-handler/src/__tests__/test-data.ts

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -36,43 +36,6 @@ export const acceptedLetterEvent = {
3636
},
3737
} as LetterEvent;
3838

39-
export const pendingLetterEvent = {
40-
specversion: '1.0',
41-
id: '281d1b5f-a6d2-42c1-9ec4-d1fc26ad2a6f',
42-
type: 'uk.nhs.notify.supplier-api.letter.PENDING.v1',
43-
plane: 'data',
44-
dataschema:
45-
'https://notify.nhs.uk/cloudevents/schemas/supplier-api/letter.PENDING.1.0.16.schema.json',
46-
dataschemaversion: '1.0.16',
47-
source:
48-
'/data-plane/supplier-api/nhs-supplier-api-nonprod/main/update-status',
49-
subject:
50-
'letter-origin/letter-rendering/letter/32124dde-4b36-4a49-8686-e9da9cbff725_2503cbd5-6722-4e90-9fbd-5f1e96d65c22',
51-
data: {
52-
domainId:
53-
'32124dde-4b36-4a49-8686-e9da9cbff725_2503cbd5-6722-4e90-9fbd-5f1e96d65c22',
54-
status: 'PENDING',
55-
specificationId: 'notify-c5',
56-
billingRef: 'notify-c5',
57-
specificationBillingId: 'default',
58-
supplierId: 'synertec',
59-
groupId: '32124dde-4b36-4a49-8686-e9da9cbff725digitalLettersundefined',
60-
origin: {
61-
domain: 'letter-rendering',
62-
source: '/data-plane/digital-letters/nonprod/main',
63-
subject:
64-
'client/32124dde-4b36-4a49-8686-e9da9cbff725/letter-request/2503cbd5-6722-4e90-9fbd-5f1e96d65c22',
65-
event: '281d1b5f-a6d2-42c1-9ec4-d1fc26ad2a6f',
66-
},
67-
},
68-
time: '2026-03-27T16:59:16.515Z',
69-
datacontenttype: 'application/json',
70-
traceparent: '00-15c1d7050c2dbeb7f762bff8874c9a5b-a7043d96b780e5ef-01',
71-
recordedtime: '2026-03-27T16:59:16.515Z',
72-
severitynumber: 2,
73-
severitytext: 'INFO',
74-
} as LetterEvent;
75-
7639
export const failedLetterEvent = {
7740
id: '550e8400-e29b-41d4-a716-446655440002',
7841
specversion: '1.0',

0 commit comments

Comments
 (0)