Skip to content

PPHA-670: Updated page title on periods when you stopped smoking page #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Themitchell merged 2 commits into from
Mar 31, 2026
Merged

PPHA-670: Updated page title on periods when you stopped smoking page #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bc2219
fix: updated page title
stephhou Mar 31, 2026
4c637bb
Merge branch 'main' into PPHA-670-Update-former-smoking-page-title
stephhou Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lung_cancer_screening/questions/forms/periods_when_you_stopped_smoking_form.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ def label_classes(self):
else:
return "nhsuk-fieldset__legend--m"

def page_title(self):
return f"{self.label()} – NHS"


def stopped_or_quit(self):
if self.response_set().current_smoker():
Expand Down
2 changes: 0 additions & 2 deletions lung_cancer_screening/questions/jinja2/periods_when_you_stopped_smoking.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

{% from 'nhsuk/components/button/macro.jinja' import button %}

{% block pageTitle %}Have you ever stopped smoking for periods of 1 year or longer? - NHS{% endblock %}

{% if error %}
{% set error_message = { "text": error } %}
{% endif %}
Expand Down
7 changes: 7 additions & 0 deletions lung_cancer_screening/questions/views/periods_when_you_stopped_smoking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,10 @@ class PeriodsWhenYouStoppedSmokingView(LoginRequiredMixin, EnsureResponseSet, En
model = PeriodsWhenYouStoppedSmokingResponse
success_url = reverse_lazy("questions:types_tobacco_smoking")
back_link_url = reverse_lazy("questions:age_when_started_smoking")

def get_context_data(self, **kwargs):
context = super().get_context_data(**kwargs)
form = context.get("form") or self.get_form()
context["page_title"] = form.page_title()
return context

Loading