Skip to content

PPHA-670: Updated page title on periods when you stopped smoking page#425

Merged
Themitchell merged 2 commits intomainfrom
PPHA-670-Update-former-smoking-page-title
Mar 31, 2026
Merged

PPHA-670: Updated page title on periods when you stopped smoking page#425
Themitchell merged 2 commits intomainfrom
PPHA-670-Update-former-smoking-page-title

Conversation

@stephhou
Copy link
Copy Markdown
Contributor

What is the change?

  • Edited page title to be both current and past tense

Why are we making this change?

Improve usability and align with prototype v 1.4

@stephhou stephhou marked this pull request as ready for review March 31, 2026 12:13
Copilot AI review requested due to automatic review settings March 31, 2026 12:13
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the “Periods when you stopped smoking” question page so the browser page title reflects both current- and past-tense phrasing, aligning the page title with the form’s dynamic label (and the referenced prototype v1.4).

Changes:

  • Removed the hard-coded {% block pageTitle %} from the Jinja template.
  • Added a dynamic page_title() helper to the form, based on the existing label() logic.
  • Updated the view to populate page_title in the template context using the form’s page_title().

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
lung_cancer_screening/questions/views/periods_when_you_stopped_smoking.py Sets page_title dynamically in context based on the form instance.
lung_cancer_screening/questions/jinja2/periods_when_you_stopped_smoking.jinja Removes hard-coded page title block so layout uses the provided page_title.
lung_cancer_screening/questions/forms/periods_when_you_stopped_smoking_form.py Adds page_title() derived from dynamic label() (current vs past tense).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Themitchell Themitchell merged commit 8c00a81 into main Mar 31, 2026
25 checks passed
@Themitchell Themitchell deleted the PPHA-670-Update-former-smoking-page-title branch March 31, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants