PPHA-670: Updated page title on periods when you stopped smoking page#425
Merged
Themitchell merged 2 commits intomainfrom Mar 31, 2026
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the “Periods when you stopped smoking” question page so the browser page title reflects both current- and past-tense phrasing, aligning the page title with the form’s dynamic label (and the referenced prototype v1.4).
Changes:
- Removed the hard-coded
{% block pageTitle %}from the Jinja template. - Added a dynamic
page_title()helper to the form, based on the existinglabel()logic. - Updated the view to populate
page_titlein the template context using the form’spage_title().
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lung_cancer_screening/questions/views/periods_when_you_stopped_smoking.py |
Sets page_title dynamically in context based on the form instance. |
lung_cancer_screening/questions/jinja2/periods_when_you_stopped_smoking.jinja |
Removes hard-coded page title block so layout uses the provided page_title. |
lung_cancer_screening/questions/forms/periods_when_you_stopped_smoking_form.py |
Adds page_title() derived from dynamic label() (current vs past tense). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Themitchell
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What is the change?
Why are we making this change?
Improve usability and align with prototype v 1.4