-
Notifications
You must be signed in to change notification settings - Fork 2
test: Added Tests to ValidationHelper.cs #816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78 changes: 78 additions & 0 deletions
78
tests/UnitTests/SharedTests/ValidationHelperTests/ValidationHelperTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| namespace NHS.CohortManager.Tests.Shared; | ||
|
|
||
|
|
||
| using Common; | ||
|
|
||
| [TestClass] | ||
| public class ValidationHelperTests | ||
| { | ||
| [TestMethod] | ||
| [DataRow("20000101")] // yyyymmdd | ||
| [DataRow("200001")] // yyyymm | ||
| [DataRow("2000-01-01")] // yyyy-mm-dd | ||
| [DataRow("01/01/2000 12:00:00")] // dd/mm/yyyy hh:mm:ss | ||
| [DataRow("2000")] // yyyy | ||
| public void ValidatePastDate_ValidInput_ReturnTrue(string date) | ||
| { | ||
| //No Arrange | ||
| //Act | ||
| var actual = ValidationHelper.ValidatePastDate(date); | ||
|
|
||
| //Assert | ||
| bool expected = true; | ||
| Assert.AreEqual(actual, expected); | ||
| } | ||
|
|
||
| [TestMethod] | ||
| [DataRow(null)] // null | ||
| [DataRow("20300101")] // future date | ||
| [DataRow("2000-01-32")] // date doesn't exist | ||
| [DataRow("1/13/2000 12:00:00 01")] // d/mm/yyyy hh:mm:ss tt | ||
| [DataRow("01/01/2000 25:00:00 01")] // dd/mm/yyyy hh:mm:ss tt | ||
| [DataRow("-2000")] // negative year | ||
| public void ValidatePastDate_InvalidInput_ReturnFalse(string date) | ||
| { | ||
| //No Arrange | ||
| //Act | ||
| var actual = ValidationHelper.ValidatePastDate(date); | ||
|
|
||
| //Assert | ||
| bool expected = false; | ||
| Assert.AreEqual(actual, expected); | ||
| } | ||
|
|
||
| [TestMethod] | ||
| [DataRow("8919361401")] // These are random valid NHS numbers created by https://data-gorilla.uk/en/healthcare/nhs-number/ | ||
| [DataRow("4539728490")] // This does not contain PII. | ||
| [DataRow("1056154497")] | ||
| [DataRow("1201484383")] | ||
| [DataRow("8325769629")] | ||
| public void ValidateNHSNumber_ValidInput_ReturnTrue(string nhsNumber) | ||
| { | ||
| //No Arrange | ||
| //Act | ||
| var actual = ValidationHelper.ValidateNHSNumber(nhsNumber); | ||
|
|
||
| //Assert | ||
| bool expected = true; | ||
| Assert.AreEqual(actual, expected); | ||
| } | ||
|
|
||
| [TestMethod] | ||
| [DataRow(null)] | ||
| [DataRow("1234567890")] | ||
| [DataRow("-1234567890")] | ||
| [DataRow("1a2b3c4d5e")] | ||
| [DataRow("123")] | ||
| [DataRow("0000000000")] | ||
| public void ValidateNHSNumber_InvalidInput_ReturnFalse(string nhsNumber) | ||
| { | ||
| //No Arrange | ||
| //Act | ||
| var actual = ValidationHelper.ValidateNHSNumber(nhsNumber); | ||
|
|
||
| //Assert | ||
| bool expected = false; | ||
| Assert.AreEqual(actual, expected); | ||
| } | ||
| } | ||
27 changes: 27 additions & 0 deletions
27
tests/UnitTests/SharedTests/ValidationHelperTests/ValidationHelperTests.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net8.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
|
|
||
| <IsPackable>false</IsPackable> | ||
| <IsTestProject>true</IsTestProject> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="coverlet.collector" Version="6.0.0" /> | ||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" /> | ||
| <PackageReference Include="MSTest.TestAdapter" Version="3.1.1" /> | ||
| <PackageReference Include="MSTest.TestFramework" Version="3.1.1" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="../../../../application/CohortManager/src/Functions/Shared/Common/Common.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Using Include="Microsoft.VisualStudio.TestTools.UnitTesting" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we calculate a future date rather than hardcoding? this will start failing in 2030