test: Added Tests to ValidationHelper.cs#816
Closed
Joseph2910 wants to merge 4 commits intomainfrom
Closed
Conversation
andrewmorris43
previously approved these changes
Mar 14, 2025
Joseph2910
added
the
test coverage
sudipnhs
previously approved these changes
Mar 17, 2025
Co-authored-by: will-larkin-nhs <160748088+will-larkin-nhs@users.noreply.github.com>
Joseph2910
dismissed stale reviews from sudipnhs and andrewmorris43
via
6846bec
|
|
||
| [TestMethod] | ||
| [DataRow(null)] // null | ||
| [DataRow("20300101")] // future date |
Contributor
There was a problem hiding this comment.
could we calculate a future date rather than hardcoding? this will start failing in 2030
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-7738
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.