-
Notifications
You must be signed in to change notification settings - Fork 2
feat: dummy GP code management for servicenow #1434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
dd19879
feat: Update Dummy GP for serviceNow participants
Warren-Pitterson 4a1e1c5
test: Dummy GP code tests and helper method
Warren-Pitterson 19522dc
Merge branch 'main' into feat/DTOSS-9614-Add-Dummy-GP
Warren-Pitterson 9c89fdc
fix: ServiceNow Variable name conflict
Warren-Pitterson 50ff250
chore: Removed unused parameter 'participantDemographic'.
Warren-Pitterson 7b47e09
Merge branch 'main' into feat/DTOSS-9614-Add-Dummy-GP
Warren-Pitterson 5b914c1
Merge branch 'main' into feat/DTOSS-9614-Add-Dummy-GP
Warren-Pitterson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this functionality probably needs to be in the DistributeParticipant function, I'm currently adding a call to that function from ManageServiceNowParticipant and should have a PR up soon.
The problem is that the ManageServiceNowParticipant function won't know if the participant has been distributed yet, since the DistributeParticipant function has a service bus trigger. The ManageServiceNowParticipant function might be prematurely attempting to update the CohortDistribution table.