feat: dummy GP code management for servicenow#1434
Closed
Warren-Pitterson wants to merge 7 commits intomainfrom
Closed
feat: dummy GP code management for servicenow#1434Warren-Pitterson wants to merge 7 commits intomainfrom
Warren-Pitterson wants to merge 7 commits intomainfrom
Conversation
|
Contributor
There was a problem hiding this comment.
I think this functionality probably needs to be in the DistributeParticipant function, I'm currently adding a call to that function from ManageServiceNowParticipant and should have a PR up soon.
The problem is that the ManageServiceNowParticipant function won't know if the participant has been distributed yet, since the DistributeParticipant function has a service bus trigger. The ManageServiceNowParticipant function might be prematurely attempting to update the CohortDistribution table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-9614
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.