Skip to content

Fix/iops 3916 slicing #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryma2fhir wants to merge 19 commits into
base: develop
Choose a base branch
from
Open

Fix/iops 3916 slicing #734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f9d9780
updated to include ig tools needed for Forge
ryma2fhir Apr 7, 2026
3a5a629
changed base profile to hl7, added sct ValueSet as per previous itera…
ryma2fhir Apr 7, 2026
9158c3c
changed baseDefinition to hl7 vitalsigns to ensure compliance. fixed …
ryma2fhir Apr 7, 2026
623a97e
restricted valueQuantity to metric ucum codes only
ryma2fhir Apr 7, 2026
e8a9d12
Merge 623a97e51c0bd33bf22dc4c3a350cdeb763d31a5 into 053058e9c06264b93…
ryma2fhir Apr 7, 2026
479f4d3
GitHub Action: Find and Replace
ryma2fhir Apr 7, 2026
452676d
try fix for slicing disciminator
ryma2fhir Apr 7, 2026
c2571e1
Merge branch 'fix/IOPS-3916_slicing' of https://github.com/NHSDigital…
ryma2fhir Apr 7, 2026
101dc06
fix minor errors
ryma2fhir Apr 7, 2026
8ca9670
Merge 101dc0608e57c1552097ecea90ba62fc522def09 into 053058e9c06264b93…
ryma2fhir Apr 7, 2026
0129d00
GitHub Action: Find and Replace
ryma2fhir Apr 7, 2026
b5b8d70
fix minor errors
ryma2fhir Apr 7, 2026
21c27db
Merge branch 'fix/IOPS-3916_slicing' of
ryma2fhir Apr 7, 2026
7d57ac0
Fix casing in BPCodeSnomedct identifier
ryma2fhir Apr 8, 2026
ab1e970
fixed issues raised by review
ryma2fhir Apr 8, 2026
bb1e851
fix validation errors
ryma2fhir Apr 8, 2026
7d53fd5
added short value to see if validation issue is fixed
ryma2fhir Apr 8, 2026
a78b0da
readded slice
ryma2fhir Apr 8, 2026
41cea0d
changed disciminator
ryma2fhir Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions fhirpkg.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
{
"updated": "2025-08-14T14:55:55.4607406+01:00",
"updated": "2026-04-07T13:17:09.3887142+01:00",
"dependencies": {
"hl7.fhir.r4.core": "4.0.1",
"hl7.fhir.r5.core": "5.0.0"
"hl7.fhir.uv.tools.r4": "1.1.2",
"hl7.terminology.r4": "7.1.0",
"hl7.fhir.uv.extensions.r4": "5.2.0"
},
"missing": {}
}
9 changes: 5 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@
"version": "2.0.0",
"description": "UK Core FHIR profiles and Assets",
"author": "NHS Digital",
"dependencies": {
"hl7.fhir.r4.core": "4.0.1",
"hl7.fhir.uv.tools.r4": "1.1.2"
},
"fhirVersions": [
"4.0.1"
],
"dependencies": {
"hl7.fhir.r4.core": "4.0.1"
}
]
}
33 changes: 11 additions & 22 deletions structuredefinitions/UKCore-Observation-VitalSigns-BMI.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
<StructureDefinition xmlns="http://hl7.org/fhir">
<id value="UKCore-Observation-VitalSigns-BMI" />
<url value="https://fhir.hl7.org.uk/StructureDefinition/UKCore-Observation-VitalSigns-BMI" />
<version value="0.1.1" />
<version value="0.2.0" />
<name value="UKCoreObservationVitalSignsBMI" />
<title value="UK Core Observation Vital Signs BMI" />
<status value="draft" />
<date value="2025-11-06" />
<date value="2026-04-07" />
<publisher value="HL7 UK" />
<contact>
<name value="HL7 UK" />
Expand All @@ -24,36 +24,25 @@
<kind value="resource" />
<abstract value="false" />
<type value="Observation" />
<baseDefinition value="https://fhir.hl7.org.uk/StructureDefinition/UKCore-Observation-VitalSigns" />
<baseDefinition value="http://hl7.org/fhir/StructureDefinition/bmi" />
<derivation value="constraint" />
<differential>
<element id="Observation.code">
<path value="Observation.code" />
<element id="Observation.code.coding:BMICodeSnomedCT">
<path value="Observation.code.coding" />
<sliceName value="BMICodeSnomedCT" />
<binding>
<strength value="preferred" />
<valueSet value="https://fhir.hl7.org.uk/ValueSet/UKCore-BMI" />
</binding>
</element>
<element id="Observation.value[x]">
<path value="Observation.value[x]" />
<element id="Observation.code.coding:BMICodeSnomedCT.system">
<path value="Observation.code.coding.system" />
<min value="1" />
<type>
<code value="Quantity" />
</type>
<fixedUri value="http://snomed.info/sct" />
</element>
<element id="Observation.value[x].value">
<path value="Observation.value[x].value" />
<element id="Observation.code.coding:BMICodeSnomedCT.code">
<path value="Observation.code.coding.code" />
<min value="1" />
</element>
<element id="Observation.value[x].system">
<path value="Observation.value[x].system" />
<min value="1" />
<fixedUri value="http://unitsofmeasure.org" />
</element>
<element id="Observation.value[x].code">
<path value="Observation.value[x].code" />
<min value="1" />
<fixedCode value="kg/m2" />
</element>
</differential>
</StructureDefinition>
96 changes: 48 additions & 48 deletions structuredefinitions/UKCore-Observation-VitalSigns-BloodPressure.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
<StructureDefinition xmlns="http://hl7.org/fhir">
<id value="UKCore-Observation-VitalSigns-BloodPressure" />
<url value="https://fhir.hl7.org.uk/StructureDefinition/UKCore-Observation-VitalSigns-BloodPressure" />
<version value="0.1.1" />
<version value="0.2.0" />
<name value="UKCoreObservationVitalSignsBloodPressure" />
<title value="UK Core Observation Vital Signs Blood Pressure" />
<status value="draft" />
<date value="2025-11-06" />
<date value="2026-04-07" />
<publisher value="HL7 UK" />
<contact>
<name value="HL7 UK" />
Expand All @@ -24,20 +24,24 @@
<kind value="resource" />
<abstract value="false" />
<type value="Observation" />
<baseDefinition value="https://fhir.hl7.org.uk/StructureDefinition/UKCore-Observation-VitalSigns" />
<baseDefinition value="http://hl7.org/fhir/StructureDefinition/bp" />
<derivation value="constraint" />
<differential>
<element id="Observation.code">
<path value="Observation.code" />
<element id="Observation.code.coding:BPCodeSnomedCT">
<path value="Observation.code.coding" />
<sliceName value="BPCodeSnomedCT" />
</element>
<element id="Observation.code.coding:BPCodeSnomedCT.system">
<path value="Observation.code.coding.system" />
<fixedUri value="http://snomed.info/sct" />
</element>
<element id="Observation.code.coding:BPCodeSnomedCT.code">
<path value="Observation.code.coding.code" />
<binding>
<strength value="preferred" />
<valueSet value="https://fhir.hl7.org.uk/ValueSet/UKCore-BloodPressure" />
</binding>
</element>
<element id="Observation.value[x]">
<path value="Observation.value[x]" />
<max value="0" />
</element>
<element id="Observation.method">
<path value="Observation.method" />
<binding>
Expand All @@ -57,80 +61,76 @@
<targetProfile value="https://fhir.hl7.org.uk/StructureDefinition/UKCore-Device-BloodPressure" />
</type>
</element>
<element id="Observation.component">
<path value="Observation.component" />
<slicing>
<discriminator>
<type value="value" />
<path value="code.text" />
</discriminator>
<rules value="closed" />
</slicing>
<min value="1" />
<max value="2" />
</element>
<element id="Observation.component:SystolicBP">
<path value="Observation.component" />
<sliceName value="SystolicBP" />
<min value="1" />
<max value="1" />
</element>
<element id="Observation.component:SystolicBP.code">
<path value="Observation.component.code" />
<element id="Observation.component:SystolicBP.code.coding:SBPCodeSnomedCT">
<path value="Observation.component.code.coding" />
<sliceName value="SBPCodeSnomedCT" />
<binding>
<strength value="preferred" />
<valueSet value="https://fhir.hl7.org.uk/ValueSet/UKCore-BloodPressure-Systolic" />
</binding>
</element>
<element id="Observation.component:SystolicBP.code.coding:SBPCodeSnomedCT.system">
<path value="Observation.component.code.coding.system" />
<min value="1" />
<fixedUri value="http://snomed.info/sct" />
</element>
<element id="Observation.component:SystolicBP.code.coding:SBPCodeSnomedCT.code">
<path value="Observation.component.code.coding.code" />
<min value="1" />
</element>
<element id="Observation.component:SystolicBP.value[x]">
<path value="Observation.component.value[x]" />
<min value="1" />
<type>
<code value="Quantity" />
</type>
</element>
<element id="Observation.component:SystolicBP.value[x].unit">
<element id="Observation.component:SystolicBP.value[x]:valueQuantity">
<path value="Observation.component.value[x]" />
<sliceName value="valueQuantity" />
<min value="1" />
</element>
<element id="Observation.component:SystolicBP.value[x]:valueQuantity.unit">
<path value="Observation.component.value[x].unit" />
<fixedString value="millimeter of mercury" />
</element>
<element id="Observation.component:SystolicBP.value[x].system">
<path value="Observation.component.value[x].system" />
<fixedUri value="http://unitsofmeasure.org" />
</element>
<element id="Observation.component:SystolicBP.value[x].code">
<path value="Observation.component.value[x].code" />
<fixedCode value="mm[Hg]" />
</element>
<element id="Observation.component:DiastolicBP">
<path value="Observation.component" />
<sliceName value="DiastolicBP" />
<max value="1" />
</element>
<element id="Observation.component:DiastolicBP.code">
<path value="Observation.component.code" />
<element id="Observation.component:DiastolicBP.code.coding:DBPCodeSnomedCT">
<path value="Observation.component.code.coding" />
<sliceName value="DBPCodeSnomedCT" />
<binding>
<strength value="preferred" />
<valueSet value="https://fhir.hl7.org.uk/ValueSet/UKCore-BloodPressure-Diastolic" />
</binding>
</element>
<element id="Observation.component:DiastolicBP.code.coding:DBPCodeSnomedCT.system">
<path value="Observation.component.code.coding.system" />
<min value="1" />
<fixedUri value="http://snomed.info/sct" />
</element>
<element id="Observation.component:DiastolicBP.code.coding:DBPCodeSnomedCT.code">
<path value="Observation.component.code.coding.code" />
<min value="1" />
</element>
<element id="Observation.component:DiastolicBP.value[x]">
<path value="Observation.component.value[x]" />
<min value="1" />
<type>
<code value="Quantity" />
</type>
</element>
<element id="Observation.component:DiastolicBP.value[x].unit">
<element id="Observation.component:DiastolicBP.value[x]:valueQuantity">
<path value="Observation.component.value[x]" />
<sliceName value="valueQuantity" />
</element>
<element id="Observation.component:DiastolicBP.value[x]:valueQuantity.unit">
<path value="Observation.component.value[x].unit" />
<fixedString value="millimeter of mercury" />
</element>
<element id="Observation.component:DiastolicBP.value[x].system">
<path value="Observation.component.value[x].system" />
<fixedUri value="http://unitsofmeasure.org" />
</element>
<element id="Observation.component:DiastolicBP.value[x].code">
<path value="Observation.component.value[x].code" />
<fixedCode value="mm[Hg]" />
</element>
</differential>
</StructureDefinition>
35 changes: 21 additions & 14 deletions structuredefinitions/UKCore-Observation-VitalSigns-BodyHeight.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
<StructureDefinition xmlns="http://hl7.org/fhir">
<id value="UKCore-Observation-VitalSigns-BodyHeight" />
<url value="https://fhir.hl7.org.uk/StructureDefinition/UKCore-Observation-VitalSigns-BodyHeight" />
<version value="0.1.1" />
<version value="0.2.0" />
<name value="UKCoreObservationVitalSignsBodyHeight" />
<title value="UK Core Observation Vital Signs Body Height" />
<status value="draft" />
<date value="2025-11-06" />
<date value="2026-04-07" />
<publisher value="HL7 UK" />
<contact>
<name value="HL7 UK" />
Expand All @@ -24,27 +24,34 @@
<kind value="resource" />
<abstract value="false" />
<type value="Observation" />
<baseDefinition value="https://fhir.hl7.org.uk/StructureDefinition/UKCore-Observation-VitalSigns" />
<baseDefinition value="http://hl7.org/fhir/StructureDefinition/bodyheight" />
<derivation value="constraint" />
<differential>
<element id="Observation.code">
<path value="Observation.code" />
<element id="Observation.code.coding:BodyHeightCodeSnomedCT">
<path value="Observation.code.coding" />
<sliceName value="BodyHeightCodeSnomedCT" />
<binding>
<strength value="preferred" />
<valueSet value="https://fhir.hl7.org.uk/ValueSet/UKCore-BodyHeightMeasurements" />
</binding>
Comment thread
ryma2fhir marked this conversation as resolved.
</element>
<element id="Observation.value[x]">
<element id="Observation.code.coding:BodyHeightCodeSnomedCT.system">
<path value="Observation.code.coding.system" />
<min value="1" />
<fixedUri value="http://snomed.info/sct" />
</element>
<element id="Observation.code.coding:BodyHeightCodeSnomedCT.code">
<path value="Observation.code.coding.code" />
<min value="1" />
</element>
<element id="Observation.value[x]:valueQuantity">
<path value="Observation.value[x]" />
<sliceName value="valueQuantity" />
<min value="1" />
<type>
<code value="Quantity" />
</type>
<binding>
<strength value="required" />
<description value="Include codes from http://unitsofmeasure.org where canonical = m" />
<valueSet value="http://hl7.org/fhir/ValueSet/all-distance-units" />
</binding>
</element>
<element id="Observation.value[x]:valueQuantity.code">
<path value="Observation.value[x].code" />
<fixedCode value="cm" />
Comment thread
ryma2fhir marked this conversation as resolved.
</element>
</differential>
</StructureDefinition>
35 changes: 19 additions & 16 deletions structuredefinitions/UKCore-Observation-VitalSigns-BodyTemperature.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
<StructureDefinition xmlns="http://hl7.org/fhir">
<id value="UKCore-Observation-VitalSigns-BodyTemperature" />
<url value="https://fhir.hl7.org.uk/StructureDefinition/UKCore-Observation-VitalSigns-BodyTemperature" />
<version value="0.1.1" />
<version value="0.2.0" />
<name value="UKCoreObservationVitalSignsBodyTemperature" />
<title value="UK Core Observation Vital Signs Body Temperature" />
<status value="draft" />
<date value="2025-11-06" />
<date value="2026-04-07" />
<publisher value="HL7 UK" />
<contact>
<name value="HL7 UK" />
Expand All @@ -24,33 +24,36 @@
<kind value="resource" />
<abstract value="false" />
<type value="Observation" />
<baseDefinition value="https://fhir.hl7.org.uk/StructureDefinition/UKCore-Observation-VitalSigns" />
<baseDefinition value="http://hl7.org/fhir/StructureDefinition/bodytemp" />
<derivation value="constraint" />
<differential>
<element id="Observation.code">
<path value="Observation.code" />
<element id="Observation.code.coding:BodyTempCodeSnomedCT">
<path value="Observation.code.coding" />
<sliceName value="BodyTempCodeSnomedCT" />
<binding>
<strength value="preferred" />
<valueSet value="https://fhir.hl7.org.uk/ValueSet/UKCore-BodyTemperature" />
</binding>
</element>
<element id="Observation.value[x]">
<element id="Observation.code.coding:BodyTempCodeSnomedCT.system">
<path value="Observation.code.coding.system" />
<min value="1" />
<fixedUri value="http://snomed.info/sct" />
</element>
<element id="Observation.code.coding:BodyTempCodeSnomedCT.code">
<path value="Observation.code.coding.code" />
<min value="1" />
</element>
<element id="Observation.value[x]:valueQuantity">
<path value="Observation.value[x]" />
<sliceName value="valueQuantity" />
<min value="1" />
<type>
<code value="Quantity" />
</type>
</element>
<element id="Observation.value[x].unit">
<element id="Observation.value[x]:valueQuantity.unit">
<path value="Observation.value[x].unit" />
<min value="1" />
<fixedString value="degree Celsius" />
</element>
<element id="Observation.value[x].system">
<path value="Observation.value[x].system" />
<fixedUri value="http://unitsofmeasure.org" />
</element>
<element id="Observation.value[x].code">
<element id="Observation.value[x]:valueQuantity.code">
<path value="Observation.value[x].code" />
<fixedCode value="Cel" />
</element>
Expand Down
Loading
Loading