Conversation
…any issues and duplications
omarisgreat
requested changes
Apr 8, 2026
Contributor
omarisgreat
left a comment
omarisgreat
left a comment
There was a problem hiding this comment.
Few changes proposed
Contributor
Author
|
For Blood pressure, value[x] = quantity needed otherwise hapi validation fails (in github and the latest version) |
omarisgreat
approved these changes
Apr 13, 2026
Contributor
omarisgreat
left a comment
omarisgreat
left a comment
There was a problem hiding this comment.
Changes look good, obviously apart from the validator bugs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re-added loinc codes by setting basedefiniton to relevant hl7 profiles. This ensures all vitalsigns profiles align and conform to HL7 international. Ensure SNOMED CT ValueSets sliced correctly. Ensured only metric values allowed in valueQuantity where neccesary