fix(man): clean up value hint roff and unix cfg gating in sync test#379
Merged
KSXGitHub merged 1 commit intoclaude/add-man-page-generation-BKX0Mfrom Mar 28, 2026
Merged
Conversation
…r unix test Agent-Logs-Url: https://github.com/KSXGitHub/parallel-disk-usage/sessions/adf0e69e-fdc7-40a5-84c0-25f92110fa5f Co-authored-by: KSXGitHub <11488886+KSXGitHub@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
KSXGitHub
March 28, 2026 12:13
View session
Performance Regression Reportscommit: 2a46374 There are no regressions. |
KSXGitHub
merged commit 1d325a3
into
claude/add-man-page-generation-BKX0M
13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two unresolved review comments from PR #378:
src/man_page.rs:parts.join("\\fI \\fR")produced needlessly noisy roff — e.g.\fI<TREE_WIDTH>\fR\fI \fR\fI<BAR_WIDTH>\fR. Replaced withparts.join(" ")so the separator is a plain space between already-italic spans:\fI<TREE_WIDTH>\fR \fI<BAR_WIDTH>\fR.tests/sync_man_page.rs:#![cfg(unix)]silently dropped the entire file on non-Unix. Sincerender_man_page()has no platform-specific code, the test compiles everywhere. Replaced with#[cfg_attr(not(unix), ignore = "...")]on the test fn per CONTRIBUTING.md convention.exports/pdu.1: Regenerated to reflect the cleaner roff output.