Feature/cli migration improvements#543
Merged
csharpfritz merged 11 commits intoFritzAndFriends:devfrom Apr 28, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- TC23/TC28 expected: lowercase ContentPlaceHolder id= (AttributeStripTransform converts IDid at order 700) - TC30/TC32 expected: add <Site>/<Content> wrapper from ContentWrapperTransform Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…nder tree When a Content component is removed from the render tree (e.g. behind an @if toggle), Blazor calls DisposeAsync() which routes through the base class BaseWebFormsComponent.Dispose(bool disposing). The previous attempt added IDisposable.Dispose() which is never called when IAsyncDisposable is already implemented on the base class. By overriding the protected virtual Dispose(bool) hook, the component now calls MasterPageContext.SetContent(ContentPlaceHolderID, null) at disposal, which triggers the subscribed ContentPlaceHolder to re-render showing its default ChildContent. Fixes: ContentPlaceHolder_ToggleOverride_SwitchesBetweenDefaultAndOverride Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… test WaitUntilState.DOMContentLoaded does not wait for the Blazor Server circuit to establish, so the toggle button click could fire before the @OnClick handler was registered. Aligns with the NetworkIdle pattern used by every other interactive test in the file. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Session: 2026-04-27-master-page-migration Requested by: Jeffrey T. Fritz Changes: - Logged 2026-04-27 master-page-migration session - Appended learnings to Forge, Cyclops, Bishop, Beast, Jubilee, Rogue, Colossus history files - No product code modified Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Archived decisions.md entries older than 2026-04-21 (201 blocks, 524KB 41KB) - Merged 11 inbox decision files into decisions.md - Added team update for semantic pattern infrastructure sprint to bishop, cyclops, forge, rogue history - Summarized history.md files >= 15KB by archiving old entries: * bishop: 23.92 KB 5.56 KB * cyclops: 19.41 KB → 1.88 KB * forge: 29.42 KB 1.4 KB * rogue: 19.52 KB 3.14 KB - Created orchestration logs for Bishop, Cyclops, Forge, Rogue, Coordinator - Created session log for semantic-pattern-catalog work - All history files now under 15KB threshold Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Archive .squad/decisions.md to decisions-archive.md - Reorganize team agent histories - Consolidate multi-agent session logs - Restructure skill catalogs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…cceptance tests - Implement pattern infrastructure for query, action, and account pages - Wire production and test registration for all semantic patterns - Add focused concrete and integration tests for pattern workflows - Update WingtipToys sample pages with latest Blazor patterns - Add WingtipToysPlaywrightFixture for acceptance test automation - Resolve merge conflicts and rebase onto upstream/dev Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
csharpfritz
force-pushed
the
feature/cli-migration-improvements
branch
from
b7e81bf to
10c5d56
Compare
Complete the WingtipToys migration acceptance test coverage for the CLI migration improvements feature. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.