Complete WingtipToys run28 benchmark and analysis

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: csharpfritz

dev-docs/migration-tests/wingtiptoys/run28/images/01-home.png

@@ -0,0 +1,107 @@
+# WingtipToys Migration Test - Run 28
+
+**Date:** 2026-04-27 18:50:28 -04:00  
+**Branch:** `feature/cli-migration-improvements`  
+**Operator:** Copilot CLI  
+**Requested by:** user
+
+---
+
+## Summary
+
+| Metric | Value |
+|--------|-------|
+| Source project | `samples/WingtipToys/WingtipToys` |
+| Output project | `samples/AfterWingtipToys` |
+| Toolkit entry point | `migration-toolkit/scripts/bwfc-migrate.ps1` |
+| Report folder | `dev-docs/migration-tests/wingtiptoys/run28` |
+| Total wall-clock time | `00:21:46` |
+| Build result | `SUCCESS (final build green, 32 warnings)` |
+| Acceptance tests | `SUCCESS (25 passed, 0 failed, 0 skipped)` |
+| Final status | `SUCCESS` |
+
+## Executive Summary
+
+Run 28 succeeded. After regenerating WingtipToys from scratch through `bwfc-migrate.ps1`, the fresh output was repaired in place until the app built cleanly enough for the existing Playwright suite, and the final acceptance gate passed 25/25 tests against `https://localhost:5001`.
+
+## Timing
+
+| Phase | Duration | Notes |
+|-------|----------|-------|
+| Preparation | `Captured in total only` | Run numbering, output cleanup, report folder creation |
+| Layer 1 toolkit migration | `Captured in total only` | `bwfc-migrate.ps1` produced 173 files from 32 Web Forms inputs |
+| Repair / migration skill work | `Captured in total only` | Repaired master-page shell, routing, services, account/cart flows, and invalid migrated pages |
+| Build validation | `00:00:04.8` | Final green `dotnet build samples\AfterWingtipToys\WingtipToys.csproj --nologo` |
+| Acceptance tests | `00:00:26.2` | Final Playwright run, 25 passed |
+| Screenshots + report | `Captured in total only` | Screenshot gallery and run report written under `run28` |
+| **Total** | `00:21:46` | |
+
+## Commands
+
+```powershell
+# Clear output
+Get-ChildItem samples\AfterWingtipToys -Force | Remove-Item -Recurse -Force
+
+# Run migration toolkit
+pwsh -File migration-toolkit\scripts\bwfc-migrate.ps1 -Path samples\WingtipToys -Output samples\AfterWingtipToys -Verbose
+
+# Build
+dotnet build samples\AfterWingtipToys\WingtipToys.csproj --nologo
+
+# Run app
+dotnet run --project samples\AfterWingtipToys\WingtipToys.csproj --no-build
+
+# Acceptance tests
+$env:WINGTIPTOYS_BASE_URL = "https://localhost:5001"
+dotnet test src\WingtipToys.AcceptanceTests\WingtipToys.AcceptanceTests.csproj --verbosity normal --nologo
+```
+
+## What Worked Well
+
+1. The toolkit correctly resolved the nested source root `samples\WingtipToys\WingtipToys` and scaffolded a complete Blazor output tree with the expected static assets.
+2. The improved master-page direction was usable in repair work: `Site.razor` could be reshaped around the `MasterPage` / `Content` / `ContentPlaceHolder` bridge instead of flattening everything into an ad hoc layout.
+3. Once the app shell, catalog/cart services, and account/cart navigation were repaired, the migrated sample satisfied the full Playwright gate without changing the test suite.
+
+## What Didn't Work Well
+
+1. The fresh generated app still copied a large non-viable compile surface (`.razor.cs`, App_Start, OWIN, EF, legacy logic) that had to be excluded or bypassed for the acceptance-path sample to build.
+2. Generated pages still contained invalid or unusable Web Forms-era output, especially around master pages, account flows, script/bundle references, and redirect-style action pages.
+3. The initial cleanup attempt was invalidated by a stale `dotnet run` process holding files open; the valid run began only after stopping PID `72232`, re-clearing `samples\AfterWingtipToys`, and rerunning Layer 1.
+
+## Build Result
+
+The final build succeeded with 32 warnings and 0 errors. Most remaining warnings are nullable-model warnings in copied legacy model classes plus one cart-service nullability warning; the major blocking error classes encountered earlier in recovery were invalid migrated page markup, missing layout wiring, validator generic inference failures, and copied OWIN/EF/App_Start code that does not belong in the repaired SSR sample.
+
+## Acceptance Test Result
+
+| Metric | Value |
+|--------|-------|
+| Total | `25` |
+| Passed | `25` |
+| Failed | `0` |
+| Skipped | `0` |
+
+Two targeted fixes were needed before the final pass: first, the cart flow had to stop landing on a routed `/AddToCart` page and instead navigate directly into `/ShoppingCart`; second, the product-details page had to expose a real **Add To Cart** button so the Playwright selector matched the migrated UI.
+
+## Toolkit Gaps Exposed by This Run
+
+1. Master-page conversion is better than run27 but still not enough on its own; generated `Site.razor` / child-page output still required substantial manual cleanup to become a functioning SSR shell.
+2. The migration output should not blindly include broken `.razor.cs`, App_Start, OWIN, EF initializer, and legacy logic surfaces when those files are known not to compile in the generated sample shape.
+3. `migration-toolkit\scripts\Migrate-NugetStaticAssets.ps1` still has a parser failure, so NuGet static asset extraction remains broken during the benchmark run.
+
+## Screenshot Gallery
+
+| Page | Screenshot |
+|------|------------|
+| Home | ![Home](images/01-home.png) |
+| Products | ![Products](images/02-products.png) |
+| Product Details | ![Product Details](images/03-product-details.png) |
+| Shopping Cart | ![Shopping Cart](images/04-shopping-cart.png) |
+| Login | ![Login](images/05-login.png) |
+| About | ![About](images/06-about.png) |
+
+## Notes
+
+- Layer 1 summary: 32 files processed, 173 files written, 80 static files copied, 2 manual items, 1 warning, 0 migration errors.
+- Final validated app URL was `https://localhost:5001`.
+- The repaired sample uses lightweight in-memory catalog, cart, and user-store services to keep the current benchmark focused on migrated UI behavior and the existing acceptance criteria.

dev-docs/migration-tests/wingtiptoys/run28/images/02-products.png

@@ -0,0 +1,3 @@
+Run: 28
+Start: 2026-04-27T18:28:42.0255200-04:00
+ReportDir: dev-docs\migration-tests\wingtiptoys\run28

dev-docs/migration-tests/wingtiptoys/run28/images/03-product-details.png

@@ -0,0 +1,228 @@
+# Wingtip Run 28 CLI Root-Cause Analysis
+
+## Goal
+
+Capture why the fresh `samples\AfterWingtipToys` output was broken after the `run28` migration, what had to be rewritten during repair, and what the CLI should do differently so future runs need far less manual work.
+
+## Core Finding
+
+The generated output failed for three overlapping reasons:
+
+1. The CLI preserved too much **raw Web Forms behavior**.
+2. The CLI converted too little **page/runtime semantics**.
+3. The CLI copied too much **legacy code that was not runnable in the generated Blazor SSR shape**.
+
+This was not just a master-page problem. Master pages were one part of a larger issue where the output looked structurally familiar but still behaved like partially copied Web Forms.
+
+## What the CLI Emitted
+
+### Master pages
+
+`MasterPageTransform` already does useful structural cleanup:
+
+- strips outer document scaffolding
+- converts `<asp:ContentPlaceHolder>` to `<ContentPlaceHolder>`
+- wraps output in `<MasterPage>`
+- extracts some `<head>` content
+
+But that is still mostly a **markup wrapper transform**, not a **runnable shell transform**.
+
+Result: generated files such as `Site.razor` still needed real migration decisions around shell composition, head assets, script/bundle references, login/cart chrome, forms, and master/content wiring.
+
+### Content pages
+
+`ContentWrapperTransform` converts:
+
+- `<asp:Content ... ContentPlaceHolderID="X">`
+- to `<Content ContentPlaceHolderID="X">`
+- and wraps the page in the master component, e.g. `<Site>...</Site>`
+
+That preserves the **shape** of content-page relationships, but not the **behavior** of the page.
+
+Result: pages still needed semantic rewrites for:
+
+- query-string binding
+- cart actions
+- login/register form behavior
+- navigation/redirect flows
+- validation behavior
+- selector-compatible UI for Playwright
+
+### Code-behind
+
+Generated `.razor.cs` files were copied with TODO comments, but many still contained Web Forms assumptions such as:
+
+- `Page.PreLoad`
+- `ViewState`
+- `HttpContext.Current`
+- `Context.GetOwinContext()`
+- EF `ProductContext` access
+- `[QueryString]` / `[RouteData]`-style patterns
+
+That left many files in an awkward middle state: present in the build, partially annotated, but not genuinely migrated.
+
+## What Actually Needed Rewriting
+
+### 1. Master-page shell files
+
+These were the highest-value runtime fixes:
+
+- `Site.razor`
+- parts of `Site.razor.cs`
+
+Why they broke:
+
+- generated shell still expected Web Forms lifecycle and anti-XSRF patterns
+- still assumed OWIN logout/auth wiring
+- still assumed server-managed chrome composition instead of a runnable Blazor SSR shell
+
+What the CLI should have emitted:
+
+- a valid SSR shell component
+- proper `ChildContent` contract
+- normalized head/static asset handling
+- Blazor-compatible login/cart/nav rendering
+
+### 2. Acceptance-path pages
+
+These pages needed semantic repair:
+
+- `Default.razor`
+- `About.razor`
+- `Contact.razor`
+- `ProductList.razor`
+- `ProductDetails.razor`
+- `ShoppingCart.razor`
+- `Account\Register.razor`
+- `Account\Login.razor`
+
+Why they broke:
+
+- content wrappers were converted, but page semantics were not
+- product lookup/query handling was still Web Forms shaped
+- add-to-cart flow still behaved like a routed action page instead of a usable SSR interaction
+- login/register behavior still assumed validator/control patterns rather than working SSR forms
+
+### 3. Build-blocker pages
+
+These pages were not all core features, but they still blocked build or runtime:
+
+- `Account\*.razor`
+- `Checkout\*.razor`
+- `Admin\AdminPage.razor`
+- `AddToCart.razor`
+- `ErrorPage.razor`
+- `ViewSwitcher.razor`
+
+Why they broke:
+
+- invalid leftover Web Forms markup
+- unsupported identity/updatepanel-era patterns
+- copied code-behind that was still only partly transformed
+
+### 4. Project surface
+
+The generated project also needed non-page repair:
+
+- `Program.cs`
+- `WingtipToys.csproj`
+
+Why they broke:
+
+- the CLI copied a broad compile surface that did not belong in a runnable repaired SSR sample
+- App_Start, OWIN, EF initializer/context, and legacy code-behind should not have been compiled as-is
+
+## Why the Current CLI Stops Short
+
+The existing transforms are still mostly **syntactic**:
+
+- **MasterPageTransform**: make the master page look like BWFC markup
+- **ContentWrapperTransform**: make content sections look like BWFC content components
+
+Wingtip needed the next layer: **semantic transforms**.
+
+## What the CLI Should Do Next
+
+### 1. Make master-page migration a first-class runnable mode
+
+The CLI should emit master pages as real BWFC shell components, not just cleaned fragments.
+
+Needed behaviors:
+
+- generate valid `ChildContent` contracts
+- normalize `<head>` assets into app-level references
+- remove or rewrite `ScriptManager`, bundle references, and server form assumptions
+- migrate login/cart/user chrome into Blazor-compatible behavior
+
+### 2. Stop compiling copied legacy code-behind by default
+
+Copied `.razor.cs` should be one of two things:
+
+1. fully migrated and compile-ready, or
+2. clearly quarantined as manual migration material
+
+The current half-migrated middle state causes most of the friction.
+
+Recommended CLI behavior:
+
+- include migrated code-behind only when transforms make it compile
+- otherwise exclude it from compile or place it in a manual-migration area
+- apply the same rule to App_Start, OWIN, EF initializer, and identity bootstrap files
+
+### 3. Add semantic transforms for common Web Forms page patterns
+
+Wingtip exposed several recurring patterns the CLI should learn directly:
+
+1. **Query-driven details pages**  
+   Convert `SelectMethod` + query-string patterns into Blazor query-bound parameters and service-backed lookups.
+
+2. **Redirect/action pages**  
+   Convert pages like `AddToCart.aspx` into a usable action flow, not a routed content page that still behaves like a page.
+
+3. **Simple account pages**  
+   Convert login/register flows into SSR-safe forms rather than preserving validator-heavy control markup that does not compile or run well.
+
+4. **Master/content contracts**  
+   When a page is wrapped in `<Site>...</Site>`, ensure the generated component contract is valid and the target master component actually expects the child content being emitted.
+
+### 4. Add compile-surface filtering
+
+The CLI should automatically recognize files that are unlikely to survive direct migration into the generated SSR app shape.
+
+For Wingtip, likely filter or quarantine:
+
+- `App_Start\*`
+- `Startup.Auth.cs`
+- `IdentityConfig.cs`
+- EF initializer/context bootstrapping files
+- copied `.razor.cs` files with unresolved Web Forms runtime assumptions
+
+### 5. Turn the benchmark findings into CLI regression tests
+
+The specific failures from run28 should become tests for:
+
+- master-page `ChildContent` / content-section wiring
+- runnable `Site.Master` conversion
+- content-page wrapping that produces valid component contracts
+- add-to-cart conversion
+- account-page form conversion
+- exclusion or quarantine of non-runnable legacy compile surface
+
+## Bottom Line
+
+The broken output was not just "master page conversion failed."
+
+It was:
+
+1. **master-page conversion preserved structure but not a runnable shell**
+2. **content-page conversion preserved wrappers but not page semantics**
+3. **legacy code-behind/app-start/identity/EF surface was copied into the build when it should have been transformed or quarantined**
+
+The next CLI improvements should focus on **semantic migration output**, not just cleaner markup transforms.
+
+## Recommended Follow-Up Work
+
+1. Add a dedicated **runnable master-page shell transform** for `.master` files.
+2. Add **pattern-based page transforms** for details, cart, and account flows.
+3. Add **compile-surface filtering/quarantine rules** for copied legacy files.
+4. Add **Wingtip benchmark regression tests** that assert those behaviors.

dev-docs/migration-tests/wingtiptoys/run28/images/04-shopping-cart.png

@@ -1,10 +1,9 @@
 @page "/About"
-<PageTitle>About</PageTitle>
 
-<h2>About</h2>
-<h3>BlazorWebFormsComponents migration benchmark</h3>
-<p>
-    Wingtip Toys is the canonical Web Forms sample used to measure the BWFC migration toolkit.
-    This repaired run preserves the classic storefront look while validating navigation,
-    catalog rendering, cart behavior, and account forms end to end.
-</p>
+<PageTitle>About</PageTitle>
+<Site>
+    <Content ContentPlaceHolderID="MainContent">
+        <h1>About</h1>
+        <p>Wingtip Toys is a sample storefront focused on transportation-themed toys and a migration-friendly shopping experience.</p>
+    </Content>
+</Site>