Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/System.Linq.Dynamic.Core/Parser/ExpressionParser.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1668,11 +1668,6 @@ Expression ParseMemberAccess(Type type, Expression instance)
throw ParseError(errorPos, Res.MethodsAreInaccessible, TypeHelper.GetTypeName(method.DeclaringType));
}

if (method.ReturnType == typeof(void))
{
throw ParseError(errorPos, Res.MethodIsVoid, id, TypeHelper.GetTypeName(method.DeclaringType));
}

if (instance == null)
{
return Expression.Call(null, method, args);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,26 @@ public int Foo()
return 42;
}

public void Bar()
{
Name = nameof(Foo);
}

public string Name { get; set; }

public MyClass Child { get; set; }
}

private class MyClassCustomTypeProvider : DefaultDynamicLinqCustomTypeProvider
{
public override HashSet<Type> GetCustomTypes()
{
var customTypes = base.GetCustomTypes();
customTypes.Add(typeof(MyClass));
return customTypes;
}
}

private class ComplexParseLambda1Result
{
public int? Age;
Expand Down Expand Up @@ -1197,5 +1212,23 @@ public void DynamicExpressionParser_ParseLambda_NullPropagation_MethodCallExpres
// Assert
result.Should().BeNull();
}

[Fact]
public void DynamicExpressionParser_ParseLambda_ActionDelegate_VoidMethodCallExpression()
{
// Arrange
var dataSource = new MyClass();
var expressionText = "it.Bar()";
var parsingConfig = new ParsingConfig { CustomTypeProvider = new MyClassCustomTypeProvider() };
dataSource.Name.Should().BeNull();

// Act
LambdaExpression expression = DynamicExpressionParser.ParseLambda(typeof(Action<MyClass>), parsingConfig, dataSource.GetType(), null, expressionText);
Delegate del = expression.Compile();
del.DynamicInvoke(dataSource);

// Assert
dataSource.Name.Should().NotBeNullOrEmpty();
}
}
}