fix build on docs.rs: doc_auto_cfg merged with doc_cfg

[amorison]

The doc_auto_cfg feature has been merged with doc_cfg. rust-lang/rust#138907

It might be worth setting up an action running cargo docs-rs to detect this sort of issues in CI. See https://github.com/syphar/cargo-docs-rs

[zhiburt]

Hi @amorison

Thank you for your commitment.
I am not sure how you spotted it)

It might be worth setting up an action running cargo docs-rs to detect this sort of issues in CI. See https://github.com/syphar/cargo-docs-rs

That's something I was experimenting with a long time ago.
And have not succeed :)

I mean I was basically figuring out the parameters docs-rs uses.

---

I am not sure whether it's safe enough to merge, since we will no longer support older compilers right?
If it's OK I'll merge it.

And if you could have time to help with CI could be great :)
Just saying :)

[amorison]

I spotted the issue on docs.rs itself, there is a warning note that the build didn't pass with an error message leading to the relevant PR: https://docs.rs/crate/tabled/0.21.0

I am not sure whether it's safe enough to merge, since we will no longer support older compilers right?

In practice cfg_attr(docsrs, ...) only gets used when building on docs.rs. You can of course configure your own environment to mimic docs.rs, but you'd have to go out of your way to do that. So the crate itself is still usable with older versions of rustc. You also have a CI action that uses your MSRV (1.83 apparently), and this passed so I think everything is fine.

And if you could have time to help with CI could be great :)

I might have some time in the coming days to have a look at the existing CI.

[amorison]

Is there anything blocking this being merged?

[zhiburt]

No I think it is cool

Thank you @amorison.
Sorry for delay, it's just work and life....I see issues/PR/comments but often forget to address or rather don't have capacity 😞 .

Once again sorry.
And thank you.

Have a great day there.
Take care.