chore!: switch from babel-eslint to @babel/eslint-parser - #176
Merged
Conversation
Francois-Esquire
approved these changes
Oct 18, 2021
mtomcal
reviewed
Oct 18, 2021
| "eslint-plugin-notice": "0.9.10", | ||
| "eslint-plugin-react": "7.26.1", | ||
| "eslint-plugin-react-hooks": "4.2.0", | ||
| "eslint-plugin-react-hooks": "4.2.1-alpha-930c9e7ee-20211015", |
There was a problem hiding this comment.
Not a fan of this but looks like it's necessary. Something we should keep our 👀 on but eslint config is in the lower risk category as a dev tool so 🤷♂️ .
Contributor
There was a problem hiding this comment.
Agreed, it should be a temporary solution for the time being.
mtomcal
approved these changes
Oct 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Defaults to the updated
@babel-eslint/parserinstead of the unmaintainedbabel-eslint. See https://www.npmjs.com/package/@babel/eslint-parser for support rationale.Details
Also bumps
eslint-plugin-react-hooksto the alpha version with support for eslint 8.x.Tested locally linked package with
yarn lint:jsonreact-componentswith version bumps for:@typescript-eslint/eslint-pluginv5.0.0@typescript-eslint/parserv5.0.0eslintv8.0.1eslint-plugin-jestv25.2.1eslint-plugin-react-hooksv4.2.1-alpha-930c9e7ee-20211015...and results in 33 expected problems (32 errors, 1 warning), most of which will be addressed by fixing for the new jest/require-hook rule.