git_graph: Add tree view for commit changed files - #58198
Conversation
|
here is a look the the feature Screen.Recording.2026-06-01.at.11.16.51.AM.mov |
|
@ChristopherBiscardi some QoL things your way! |
|
my bad, fix for clippy issues, coming right up |
74ca7d3 to
bb6ebfe
Compare
ChristopherBiscardi
left a comment
There was a problem hiding this comment.
looks good, but has conflicts that need to be resolved. Probably due to a refactor that removed the git_graph crate: #57503
|
I'll try rebasing, but probably need to refactor a lot 😔 |
bb6ebfe to
43dd234
Compare
|
Hi @chirivelli — we independently built the same feature (mine is #58416, which closes #28104). Rather than have two competing PRs, I'd love to combine the best of both so the maintainers have one strong path to merge. A few things yours does that I think are genuinely better:
And a few things from mine that I think are worth folding in regardless of which PR lands:
Happy to do the work here (or simply close mine) and follow @ChristopherBiscardi's lead. |
|
Thanks for rebasing @chirivelli @dandv If you want to make additional PRs for tests or future-proofing the compaction helper and such feel free to. |
|
@dandv great points!, feel free to fix those issues and add tests. |
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Summary: - Added a toggleable tree view for changed files in the git graph commit details panel - Reused shared ListItem rows and file icon folder rendering for changed-file entries - Kept flat view available for status-sorted changed files Tests: - cargo check -p git_graph Release Notes: - Improved commit details changed-file lists with an optional tree view
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Summary: - Added a toggleable tree view for changed files in the git graph commit details panel - Reused shared ListItem rows and file icon folder rendering for changed-file entries - Kept flat view available for status-sorted changed files Tests: - cargo check -p git_graph Release Notes: - Improved commit details changed-file lists with an optional tree view
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Summary: - Added a toggleable tree view for changed files in the git graph commit details panel - Reused shared ListItem rows and file icon folder rendering for changed-file entries - Kept flat view available for status-sorted changed files Tests: - cargo check -p git_graph Release Notes: - Improved commit details changed-file lists with an optional tree view
Self-Review Checklist:
Summary:
Tests:
Release Notes: