[ZIP 230, ZIP 246] Fixing rendering issue, and adding transparent_sighash_infos_digest - #1077
Merged
Conversation
…d adding notes to the relevant subsections of the auth_digest
daira
reviewed
Aug 31, 2025
This was referenced Sep 1, 2025
Merged
vivek-arte
changed the title
transparent_sighash_infos_digest
vivek-arte
commented
Sep 2, 2025
vivek-arte
left a comment
vivek-arte
left a comment
Contributor
Author
There was a problem hiding this comment.
Added a self-review for some points that need discussion/clarification
str4d
requested changes
Sep 2, 2025
Co-authored-by: Jack Grigg <thestr4d@gmail.com>
daira
reviewed
Sep 3, 2025
daira
reviewed
Sep 3, 2025
nuttycom
marked this pull request as draft
September 9, 2025 17:21
vivek-arte
force-pushed
the
render_fixes
branch
from
September 9, 2025 22:03
b47c5b5 to
4e69d0b
Compare
str4d
marked this pull request as ready for review
September 9, 2025 22:33
str4d
approved these changes
Sep 9, 2025
str4d
left a comment
str4d
left a comment
Collaborator
There was a problem hiding this comment.
ACK e3c915c with @daira, @nuttycom, @SamHSmith, @aphelionz.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rendered version of ZIP 230 had a system warning due to a short underline, and a missing reference. I added those in here.
I also resolved the TODO for the authorizing data commitment, per discussions in ZSA meetings.
Here are also the rendered versions of ZIP 246 and ZIP 230.