Skip to content

ci: fix rolling-upgrade - #711

Open
fegmorte wants to merge 7 commits into
mainfrom
fred/ci/fix-rolling-upgrade-ci
Open

ci: fix rolling-upgrade#711
fegmorte wants to merge 7 commits into
mainfrom
fred/ci/fix-rolling-upgrade-ci

Conversation

@fegmorte

Copy link
Copy Markdown
Contributor

Description

Related issue(s)

PR Checklist

Tick all that apply — by ticking I attest the item holds; justify any deviation in the description above.

  • Title follows conventional commits (e.g. chore: ...).
  • Tests added for every new pub item and test coverage has not decreased.
  • Public APIs and non-obvious logic documented; unfinished work marked TODO(#issue).
  • unwrap/expect/panic only in tests or for invariant bugs (documented if present).
  • No dependency version changes OR (if changed) only minimal required fixes.
  • No architectural protocol changes OR linked spec PR/issue provided.
  • No breaking deployment config / Helm chart / telemetry changes OR devops label + infra notified + review requested.
  • No breaking gRPC / serialized data changes OR commit marked with ! and affected teams notified.
  • No modifications to existing versionized structs OR backward compatibility tests updated.
  • No critical business logic / crypto changes OR ≥2 reviewers assigned.
  • No new sensitive data fields OR Zeroize + ZeroizeOnDrop implemented.
  • No new public storage data OR data is verifiable (signature / digest).
  • No unsafe; if unavoidable: minimal, justified, documented, and test/fuzz covered.
  • Strongly typed boundaries: typed inputs validated at the edge; no untyped values or errors cross modules.
  • Self-review completed.

Dependency Update Questionnaire (only if deps changed or added)

  1. Ownership changes or suspicious concentration?
  2. Low popularity?
  3. Unusual version jump?
  4. Lacking documentation?
  5. Missing CI?
  6. No security / disclosure policy?
  7. Significant size increase?

More details in CONTRIBUTING.md and AGENTS.md.

@fegmorte
fegmorte requested a review from a team as a code owner July 13, 2026 18:10
@cla-bot cla-bot Bot added the cla-signed The CLA has been signed. label Jul 13, 2026
@dvdplm

dvdplm commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Hmm, not sure I understand what is going on here. The diff look a bit weird? The two perf-test files are added, but they are not new files?

@dd23

dd23 commented Jul 28, 2026

Copy link
Copy Markdown
Member

I think this one is superseded by #713, so it can probably be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants