fix(ci): Migrate to runson and remove slab - #542
Merged
Conversation
Consolidated Tests Results 2026-05-12 - 08:06:44Test ResultsDetails
test-reporter: Run #2078
🎉 All tests passed!TestsView All Tests
🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
fegmorte
marked this pull request as ready for review
May 12, 2026 07:30
fegmorte
requested review from
aquint-zama and
maksymsur
and removed request for
aquint-zama
May 12, 2026 08:28
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates several CI workflows away from the SLAB-managed ephemeral EC2 runner model to RunsOn-managed runners, removing SLAB secrets and runner lifecycle jobs.
Changes:
- Removed SLAB start/stop runner jobs and SLAB secrets from rolling-upgrade and performance workflows; switched those jobs to RunsOn runner labels.
- Updated kind-testing to run directly on RunsOn runner labels (matrix) and removed SLAB secret requirements/start-stop runner jobs.
- Removed SLAB secret requirements from reusable docker-build workflow and deleted the now-unused
common-docker-big-instanceworkflow (plus CODEOWNERS cleanup).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/rolling-upgrade-testing.yml | Removes SLAB runner lifecycle and uses RunsOn runner label for the main job. |
| .github/workflows/performance-testing.yml | Removes SLAB runner lifecycle and uses RunsOn runner label for the main job. |
| .github/workflows/kind-testing.yml | Switches matrix to RunsOn runner labels; removes SLAB secrets/start-stop jobs; adds RunsOn metrics step; adjusts some installs. |
| .github/workflows/docker-build.yml | Drops SLAB secrets from workflow_call contract. |
| .github/workflows/common-docker-big-instance.yml | Deleted (SLAB-based reusable workflow no longer needed). |
| .github/workflows/build-and-test.yml | Stops passing SLAB secrets to called workflows. |
| .github/CODEOWNERS | Removes CODEOWNERS entry for deleted workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue ticket number and link
PR Checklist
I attest that all checked items are satisfied. Any deviation is clearly justified above.
chore: ...).TODO(#issue).unwrap/expect/paniconly in tests or for invariant bugs (documented if present).devopslabel + infra notified + infra-team reviewer assigned.!and affected teams notified.Zeroize+ZeroizeOnDropimplemented.unsafe; if unavoidable: minimal, justified, documented, and test/fuzz covered.Dependency Update Questionnaire (only if deps changed or added)
Answer in the
Cargo.tomlnext to the dependency (or here if updating):More details and explanations for the checklist and dependency updates can be found in CONTRIBUTING.md