Skip to content

fix(ci): Migrate to runson and remove slab - #542

Merged
fegmorte merged 10 commits into
mainfrom
fred/ci/migration-to-runson
May 12, 2026
Merged

fix(ci): Migrate to runson and remove slab#542
fegmorte merged 10 commits into
mainfrom
fred/ci/migration-to-runson

Conversation

@fegmorte

Copy link
Copy Markdown
Contributor

Description of changes

Issue ticket number and link

PR Checklist

I attest that all checked items are satisfied. Any deviation is clearly justified above.

  • Title follows conventional commits (e.g. chore: ...).
  • Tests added for every new pub item and test coverage has not decreased.
  • Public APIs and non-obvious logic documented; unfinished work marked as TODO(#issue).
  • unwrap/expect/panic only in tests or for invariant bugs (documented if present).
  • No dependency version changes OR (if changed) only minimal required fixes.
  • No architectural protocol changes OR linked spec PR/issue provided.
  • No breaking deployment config changes OR devops label + infra notified + infra-team reviewer assigned.
  • No breaking gRPC / serialized data changes OR commit marked with ! and affected teams notified.
  • No modifications to existing versionized structs OR backward compatibility tests updated.
  • No critical business logic / crypto changes OR ≥2 reviewers assigned.
  • No new sensitive data fields added OR Zeroize + ZeroizeOnDrop implemented.
  • No new public storage data OR data is verifiable (signature / digest).
  • No unsafe; if unavoidable: minimal, justified, documented, and test/fuzz covered.
  • Strongly typed boundaries: typed inputs validated at the edge; no untyped values or errors cross modules.
  • Self-review completed.

Dependency Update Questionnaire (only if deps changed or added)

Answer in the Cargo.toml next to the dependency (or here if updating):

  1. Ownership changes or suspicious concentration?
  2. Low popularity?
  3. Unusual version jump?
  4. Lacking documentation?
  5. Missing CI?
  6. No security / disclosure policy?
  7. Significant size increase?

More details and explanations for the checklist and dependency updates can be found in CONTRIBUTING.md

@cla-bot cla-bot Bot added the cla-signed The CLA has been signed. label Apr 22, 2026
@github-actions

github-actions Bot commented Apr 22, 2026

Copy link
Copy Markdown

Consolidated Tests Results 2026-05-12 - 08:06:44

Test Results

passed 7 passed

Details

tests 7 tests
clock not captured
tool junit-to-ctrf
build build-and-test arrow-right test-reporter link #2078
pull-request fix(ci): Migrate to runson and remove slab link #542

test-reporter: Run #2078

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
7 7 0 0 0 0 0 not captured

🎉 All tests passed!

Tests

View All Tests
Test Name Status Flaky Duration
k8s_test_crs_uniqueness 40.6s
k8s_test_insecure_keygen_encrypt_and_public_decrypt 2m 9s
k8s_test_insecure_keygen_encrypt_multiple_types 2m 24s
k8s_test_keygen_and_crs 2m 5s
k8s_test_keygen_uniqueness 5m 16s
k8s_test_centralized_insecure 1m
nightly_full_gen_tests_default_k8s_centralized_sequential_crs 1.7s

🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@fegmorte
fegmorte marked this pull request as ready for review May 12, 2026 07:30
@fegmorte
fegmorte requested review from a team as code owners May 12, 2026 07:30
@fegmorte
fegmorte requested review from aquint-zama and maksymsur and removed request for aquint-zama May 12, 2026 08:28
@maksymsur
maksymsur requested a review from Copilot May 12, 2026 08:44

@maksymsur maksymsur left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates several CI workflows away from the SLAB-managed ephemeral EC2 runner model to RunsOn-managed runners, removing SLAB secrets and runner lifecycle jobs.

Changes:

  • Removed SLAB start/stop runner jobs and SLAB secrets from rolling-upgrade and performance workflows; switched those jobs to RunsOn runner labels.
  • Updated kind-testing to run directly on RunsOn runner labels (matrix) and removed SLAB secret requirements/start-stop runner jobs.
  • Removed SLAB secret requirements from reusable docker-build workflow and deleted the now-unused common-docker-big-instance workflow (plus CODEOWNERS cleanup).

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/rolling-upgrade-testing.yml Removes SLAB runner lifecycle and uses RunsOn runner label for the main job.
.github/workflows/performance-testing.yml Removes SLAB runner lifecycle and uses RunsOn runner label for the main job.
.github/workflows/kind-testing.yml Switches matrix to RunsOn runner labels; removes SLAB secrets/start-stop jobs; adds RunsOn metrics step; adjusts some installs.
.github/workflows/docker-build.yml Drops SLAB secrets from workflow_call contract.
.github/workflows/common-docker-big-instance.yml Deleted (SLAB-based reusable workflow no longer needed).
.github/workflows/build-and-test.yml Stops passing SLAB secrets to called workflows.
.github/CODEOWNERS Removes CODEOWNERS entry for deleted workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/kind-testing.yml
@fegmorte
fegmorte merged commit ed1eea3 into main May 12, 2026
64 checks passed
@fegmorte
fegmorte deleted the fred/ci/migration-to-runson branch May 12, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants