Skip to content

helm-chart: allow configmaps instead of endpoints for leader elections… - #1037

Merged
FxKu merged 3 commits into
zalando:masterfrom
Gottox:fix-sa-for-configmaps-le
Dec 16, 2020
Merged

FxKu merged 3 commits into
zalando:masterfrom
Gottox:fix-sa-for-configmaps-le

Conversation

@Gottox

@Gottox Gottox commented Jun 29, 2020

Copy link
Copy Markdown
Contributor

This fixes leader election in 1.5 on Openshift.

Comment thread charts/postgres-operator/templates/clusterrole-postgres-pod.yaml Outdated
@Gottox

Gottox commented Jun 30, 2020

Copy link
Copy Markdown
Contributor Author

Any idea what's wrong with the tests? I can't see how my change has triggered the issue.

@ReSearchITEng

ReSearchITEng commented Jul 3, 2020

Copy link
Copy Markdown
Contributor

Can we get a similar condition also for operator roles? There should be no need even for get endpoints.

# to manage endpoints which are also used by Patroni

@Gottox

Gottox commented Jul 3, 2020

Copy link
Copy Markdown
Contributor Author

@ReSearchITEng applied!

@FxKu

FxKu commented Jul 10, 2020

Copy link
Copy Markdown
Contributor

@Gottox can you change the operator cluster role in the same way? Because the operator can also create a binding between the postgres-pod clusterrole and pod service account, but IIRC requires to have at least the same privileges for this. So if the pod role has a section for endpoints and the operator role lacks it, this operation would fail, I think.

@Gottox

Gottox commented Jul 24, 2020

Copy link
Copy Markdown
Contributor Author

I'm currently on vacations, will do it on monday! 😄

@FxKu

FxKu commented Sep 24, 2020

Copy link
Copy Markdown
Contributor

@Gottox any chance you can have a look at this PR again and update the cluster role? Thanks!

@FxKu FxKu added this to the 1.6 milestone Dec 16, 2020
@Jan-M

Jan-M commented Dec 16, 2020

Copy link
Copy Markdown
Contributor

👍

1 similar comment
@FxKu

FxKu commented Dec 16, 2020

Copy link
Copy Markdown
Contributor

👍

@FxKu
FxKu merged commit 4b90809 into zalando:master Dec 16, 2020
@FxKu

FxKu commented Dec 16, 2020

Copy link
Copy Markdown
Contributor

Thanks @Gottox for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants