[Pg-kit]: Drop identity before changing a column's type - #1
Closed
yyuneu wants to merge 2 commits into
Closed
Conversation
Postgres allows identity only on integer types, so SET DATA TYPE issued before DROP IDENTITY failed (drizzle-team#4178).
Covers dropping identity while changing the column type and default in one alter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the statement order reported in drizzle-team#4178.
When a column loses its identity and changes type in the same alter,
alterColumnConvertoremittedSET DATA TYPE(andSET DEFAULT) beforeDROP IDENTITY. Postgres rejects both while the identity is still attached (identity column type must be smallint, integer, or bigint/column ... is an identity column), so bothgenerateoutput andpushfailed.DROP IDENTITYis now emitted before the type and default changes. Added a regression test intests/postgres/pg-identity.test.tsthat runs the statements on PGlite.Limitations: the
integer → uuidcase from the issue still needs a manualUSINGexpression, since Postgres has no integer→uuid cast. The same ordering exists indialects/cockroach/convertor.tsand is left for a follow-up.