Skip to content
This repository was archived by the owner on May 2, 2022. It is now read-only.

lock prometheus-client as 0.9.x so as to keep compatibility#7

Closed
sat0yu wants to merge 1 commit into
yuya-takeyama:masterfrom
sat0yu:sat0yu/lock-prometheus-client
Closed

lock prometheus-client as 0.9.x so as to keep compatibility#7
sat0yu wants to merge 1 commit into
yuya-takeyama:masterfrom
sat0yu:sat0yu/lock-prometheus-client

Conversation

@sat0yu

@sat0yu sat0yu commented Oct 24, 2019

Copy link
Copy Markdown

The latest version (v0.10.0) of prometheus-client includes a breaking change.

- def counter(name, docstring, base_labels = {})
+ def counter(name, docstring:, labels: [], preset_labels: {}, store_settings: {})
1: from /vendor/bundle/2.5.3/gems/grpc_prometheus-0.1.0/lib/grpc_prometheus/server_metrics.rb:12:in `initialize'
/vendor/bundle/2.5.3/gems/prometheus-client-0.10.0/lib/prometheus/client/registry.rb:40:in `counter': wrong number of arguments (given 2, expected 1; required keyword: docstring) (ArgumentError)

However, v0.10.0 is yet to be officially released yet.
So, In order to avoid exceptions there, could it be possible for this gem to fix the dependency's version until gaining the compatibility?

@yuya-takeyama

Copy link
Copy Markdown
Owner

I apologize for not being responsive.
This repository is no longer maintained and will be closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants