WIP: Add hindent support and bash script - #150
Open
amitaibu wants to merge 2 commits into
Open
Conversation
amitaibu
commented
Jun 12, 2017
| Nothing -> getApprootText guessApproot app req | ||
| Just root -> root | ||
|
|
||
| where |
Author
There was a problem hiding this comment.
apparently some things are still off.
Member
There was a problem hiding this comment.
That's easy to work around with a change to the source. I'll push that into a separate commit. I'm still not sure about the change overall though...
Member
|
I have two high-level concerns with doing this:
|
Author
If I understand correctly hident is just a prettifier. That is, it doesn't deal at all with (re-)saving the files. Maybe we could add it as a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR will add format files using
hindentand will add a bash script to run it all on files.Currently the bash script needs to exclude
src/Settings.hsdue to a known bug.I've opened PR as work in progress, just to confirm it is a desired change. If so, I'll work on finalizing it.
The
.haskell-ghc-mod.jsonis there to suppress errors in editors such as atom, that might get confused with multiple ghc installations.