fix(security): prevent pwn-request vulnerability in gen_docs workflow - #4850
Merged
Conversation
qinxuye
commented
Apr 25, 2026
qinxuye
commented
Contributor
- Only execute gen_docs.py from base branch, not from PR
- Copy templates from base branch instead of using PR versions
- Use pull_request_target with explicit base SHA checkout
- Add paths filter to trigger only on model spec changes
- Remove complex file change detection (handled by paths filter)
- Support both same-repo and fork PRs safely
- Only execute gen_docs.py from base branch, not from PR - Copy templates from base branch instead of using PR versions - Use pull_request_target with explicit base SHA checkout - Add paths filter to trigger only on model spec changes - Remove complex file change detection (handled by paths filter) - Support both same-repo and fork PRs safely
codingl2k1
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.