Generalize timeout tests. Fix twitter timeout. - #131
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
==========================================
+ Coverage 78.63% 78.81% +0.17%
==========================================
Files 15 15
Lines 323 321 -2
Branches 2 2
==========================================
- Hits 254 253 -1
+ Misses 69 68 -1
Continue to review full report at Codecov.
|
peterneyens
force-pushed
the
peter-generalize-timout-tests
branch
from
August 18, 2017 16:20
67e7f2f to
2aa7bc8
Compare
raulraja
approved these changes
Aug 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I generalized the tests which check if a
FetchMonadErrorcan timeout aQuery.Before, two tests didn't actually run for both
TwitterFutureandRerunnable, because they were asynchronous and the tests stopped before the results were returned. One of these tests failed forTwitterFutureandRerunnable.When a
Timoutwas set for a asynchronousQueryit would always time out.Timer.Nilwas used to execute the timeouts, which invokes tasks immediately. I changed it toJavaTimerwhich is based onjava.util.Timer(which is already used in the timeout forscala.concurrent.Future).