Expose caching ZK artifacts as an artifact source - #463
Open
Dzejkop wants to merge 3 commits into
Open
Conversation
Dzejkop
marked this pull request as ready for review
August 6, 2026 14:02
0xOsiris
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
CachingZkArtifacts.as_zk_artifact_sourceWalletKitZkArtifactSourcetrait object required by UniFFI consumersWhy
Rust blanket trait implementations are not represented as Swift or Kotlin class inheritance. The generated mobile bindings therefore could construct and preload
CachingZkArtifacts, but could not pass it to authenticator initializers acceptingWalletKitZkArtifactSource.Impact
Swift and Kotlin consumers can now call
asZkArtifactSource()after preloading and pass the result to authenticator initialization.Validation
cargo +nightly fmt --all -- --checknix develop --command cargo check -p walletkit-core --all-featuresasZkArtifactSource()returnsWalletKitZkArtifactSourceNote
Low Risk
Small FFI surface addition with no change to ZK loading, caching, or authenticator logic beyond how types are passed across bindings.
Overview
Adds
as_zk_artifact_source()onCachingZkArtifactsandEmbeddedZkArtifacts, returningArc<dyn WalletKitZkArtifactSource>so Swift and Kotlin can pass preloaded/cached sources into authenticator setup.UniFFI does not surface Rust blanket
WalletKitZkArtifactSourceimpls as subclassing, so mobile code could build and preload these types but could not satisfy APIs that take the trait object until this explicit conversion exists.Reviewed by Cursor Bugbot for commit d7a5f09. Bugbot is set up for automated code reviews on this repo. Configure here.