-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Use workerd's compatibility date for Cloudflare defaults #17819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
0f7afc1
fix(cli): use hardcoded compatibility_date in `astro add cloudflare` …
factory[bot] a377ef2
fix(cloudflare): use workerd compatibility date
matthewp 30bebfb
fix: preserve Vitest Vite resolution
matthewp 9dfd074
docs(cloudflare): document Wrangler requirement
matthewp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| 'astro': patch | ||
| '@astrojs/cloudflare': patch | ||
| --- | ||
|
|
||
| Updates generated and default Cloudflare `compatibility_date` values to match the installed runtime and requires Wrangler `^4.125.0` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import { createRequire } from 'node:module'; | ||
| import { pathToFileURL } from 'node:url'; | ||
|
|
||
| interface CloudflareInfo { | ||
| getLocalWorkerdCompatibilityDate(): { date: string }; | ||
| } | ||
|
|
||
| export async function getCloudflareCompatibilityDate(root: URL): Promise<string> { | ||
| const require = createRequire(root); | ||
| const infoPath = require.resolve('@astrojs/cloudflare/info'); | ||
| const infoUrl = pathToFileURL(infoPath).toString(); | ||
| const infoModule = (await import(infoUrl)) as CloudflareInfo; | ||
| return infoModule.getLocalWorkerdCompatibilityDate().date; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import assert from 'node:assert/strict'; | ||
| import { mkdir, mkdtemp, rm, writeFile } from 'node:fs/promises'; | ||
| import { tmpdir } from 'node:os'; | ||
| import { join } from 'node:path'; | ||
| import { describe, it } from 'node:test'; | ||
| import { pathToFileURL } from 'node:url'; | ||
| import { getCloudflareCompatibilityDate } from '../../../dist/cli/add/cloudflare.js'; | ||
|
|
||
| describe('astro add cloudflare', () => { | ||
| it('uses the compatibility date exported by the installed adapter', async () => { | ||
| const projectDir = await mkdtemp(join(tmpdir(), 'astro-add-cloudflare-')); | ||
| const adapterDir = join(projectDir, 'node_modules', '@astrojs', 'cloudflare'); | ||
|
|
||
| try { | ||
| await mkdir(adapterDir, { recursive: true }); | ||
| await writeFile( | ||
| join(adapterDir, 'package.json'), | ||
| JSON.stringify({ | ||
| name: '@astrojs/cloudflare', | ||
| type: 'module', | ||
| exports: { './info': './info.js' }, | ||
| }), | ||
| ); | ||
| await writeFile( | ||
| join(adapterDir, 'info.js'), | ||
| `export function getLocalWorkerdCompatibilityDate() { | ||
| return { date: '2026-08-15', source: 'workerd' }; | ||
| } | ||
| `, | ||
| ); | ||
|
|
||
| const date = await getCloudflareCompatibilityDate(pathToFileURL(`${projectDir}/`)); | ||
|
|
||
| assert.equal(date, '2026-08-15'); | ||
| } finally { | ||
| await rm(projectDir, { recursive: true, force: true }); | ||
| } | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export { getLocalWorkerdCompatibilityDate } from '@cloudflare/vite-plugin'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.