spaceless tag replaced with apply filter#55
Merged
Conversation
bennothommo
approved these changes
Jan 2, 2023
Member
|
@bennothommo I didn't merge right away because it would mean that this plugin would no longer be compatible with < v1.2 of Winter, but I'm fine with it if you are. |
Member
|
It should still be compatible. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR
spacelesstag is replaced withapply spacelessTwig filter. As documented in https://github.com/wintercms/meta/blob/master/l9-upgrade-notes.md#twig for Winter 1.2. Althoughspacelessis backported, I think this may avoid issues in future if for any reason backportedspacelesswould be removed.