refactor: migrate provider base to ES6 class

[KristjanESPERANTO]

This removes legacy inheritance usage while keeping the existing provider API (register/initialize) behavior compatible, so current provider files continue to work unchanged.

Also future-proofs the module in case Class is removed in an upcoming MagicMirror release.

[winstonma]

Thanks. But I just have one tiny question (not related to this PR).

Do you know why performWebRequest was removed but not keep as a helper function. If that's the code all the downstream module would not need to make changes. I think it would be a surprise if the downstream module suddenly won't work.

[KristjanESPERANTO]

Good question. performWebRequest was removed in #4032 as part of the migration to server-side fetching via HTTPFetcher. Keeping it as a client-side shim wouldn't have made sense since the whole architecture shifted - fetching now happens in the node helper, not in the browser. And only 3 3rd-party modules used performWebRequest.

Is there a specific case you have in mind?

[winstonma]

Is there a specific case you have in mind?

No I am just curious because removing an API could break downstream modules. So I would keep the API and do the implementation inside the performWebRequest function just to avoid breaking things.

And only 3 3rd-party modules used performWebRequest

How can I find out this?

[KristjanESPERANTO]

How can I find out this?

By cloning all 1400+ modules and then search through them.

Since I'm working on the module list page I'm already have all modules cloned.

... just to avoid breaking things

Of course, we try to avoid breaking changes, but if only one-tenth of one percent of the modules uses a function that can be replaced with something more modern, the decision isn't a difficult one. We now put more effort on security, and to make progress there, we need to reevaluate some of the old patterns. That creates friction, but I try to keep it to a minimum. Part of that is by creating PRs like this one.

[winstonma]

Thanks for the explanation. That makes sense.