Skip to content

Issue #711: wicketstuff-input-events - accumulating event listeners on AJAX components - #1517

Merged
solomax merged 1 commit into
wicket-9.xfrom
bugfix/711-wicketstuff-input-events-accumulating-event-listeners-on-AJAX-components
Aug 3, 2026
Merged

Issue #711: wicketstuff-input-events - accumulating event listeners on AJAX components#1517
solomax merged 1 commit into
wicket-9.xfrom
bugfix/711-wicketstuff-input-events-accumulating-event-listeners-on-AJAX-components

Conversation

@reckart

@reckart reckart commented Jul 31, 2026

Copy link
Copy Markdown
Contributor
  • Fix keyboard shortcut listener accumulation on AJAX re-render by calling shortcut.remove() before shortcut.add() in three templates
  • Switch InputBehavior.generateString() from in-place interpolate() to non-mutating asString(variables) to preserve component state across renders
  • Add InputBehaviorRenderTest to verify scripts are re-generated from current component state per render
  • Strengthen InputEventsTest with assertions on all three template types (explicit, autohook button, autohook link) to verify shortcut registration
  • Delete vestigial WicketTestCase base class and inline its lifecycle into test subclasses
  • Remove golden-file test fixtures (Page_expectedResult.html, test.html) that were never executed
  • Enable test execution by removing surefire's "DoNotRunAnyTests" barrier and restoring inherited root configuration

(cherry picked from commit 867cc8f)

…n AJAX components

- Fix keyboard shortcut listener accumulation on AJAX re-render by calling shortcut.remove() before shortcut.add() in three templates
- Switch InputBehavior.generateString() from in-place interpolate() to non-mutating asString(variables) to preserve component state across renders
- Add InputBehaviorRenderTest to verify scripts are re-generated from current component state per render
- Strengthen InputEventsTest with assertions on all three template types (explicit, autohook button, autohook link) to verify shortcut registration
- Delete vestigial WicketTestCase base class and inline its lifecycle into test subclasses
- Remove golden-file test fixtures (Page_expectedResult.html, test.html) that were never executed
- Enable test execution by removing surefire's "DoNotRunAnyTests" barrier and restoring inherited root configuration

(cherry picked from commit 867cc8f)
@reckart reckart self-assigned this Jul 31, 2026
@reckart reckart added the bug label Jul 31, 2026
@reckart reckart added this to the 9.24.0 milestone Jul 31, 2026
@reckart

reckart commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

@solomax Here's the Wicket 9.x cherry pick

@solomax
solomax merged commit c45c3f1 into wicket-9.x Aug 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants