Skip to content

Remove references to CSP plugin-types - #6292

Merged
domenic merged 2 commits into
whatwg:mainfrom
antosart:remove-csp-plugin-types
Feb 5, 2021
Merged

Remove references to CSP plugin-types#6292
domenic merged 2 commits into
whatwg:mainfrom
antosart:remove-csp-plugin-types

Conversation

@antosart

@antosart antosart commented Jan 15, 2021

Copy link
Copy Markdown
Member

With Flash not being supported anymore, the CSP directive plugin-types
has lost its main reason for being and is being removed from the
Content Security Policy specification:
w3c/webappsec-csp#456

This change removes references to the relative algorithm in the
Content Security Policy spec.

(See WHATWG Working Mode: Changes for more details.)


/acknowledgements.html ( diff )
/iframe-embed-object.html ( diff )
/infrastructure.html ( diff )

@antosart
antosart requested a review from mikewest January 15, 2021 16:48

@domenic domenic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always excited about some cleanup!

I have a question about PDFs, which I left in w3c/webappsec-csp#456 (comment) , which we should resolve before merging this.

Comment thread source Outdated
@annevk annevk added the removal/deprecation Removing or deprecating a feature label Jan 18, 2021
With Flash not being supported anymore, the CSP directive plugin-types
has lost its main reason for being and is being removed from the
Content Security Policy specification:
w3c/webappsec-csp#456

This change removes references to the relative algorithm in the
Content Security Policy spec.
@domenic

domenic commented Jan 19, 2021

Copy link
Copy Markdown
Member

Can you restore the pull request template that was deleted, so that we can fill out the checkboxes (implementer interest, tests, bugs filed) appropriately?

@antosart

antosart commented Feb 5, 2021

Copy link
Copy Markdown
Member Author

Ok, it took me some time because of other stuff to do in between, but I opened a PR for the test: web-platform-tests/wpt#27499

@domenic domenic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks! I updated the original post to indicate this has Mozilla support (since they never shipped plugin-types), so all the boxes are checked and we can merge this now.

@domenic
domenic merged commit 72b58f2 into whatwg:main Feb 5, 2021
@annevk

annevk commented Feb 5, 2021

Copy link
Copy Markdown
Member

I think pr-preview overwrote your changes, but yeah, agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

removal/deprecation Removing or deprecating a feature topic: embed and object

Development

Successfully merging this pull request may close these issues.

3 participants