Skip to content

fResult/#5 VoteCard Component - #8

Merged
Th1nkK1D merged 5 commits into
wevisdemo:mainfrom
fResult:fResult/5-vote-card
Oct 9, 2023
Merged

fResult/#5 VoteCard Component#8
Th1nkK1D merged 5 commits into
wevisdemo:mainfrom
fResult:fResult/5-vote-card

Conversation

@fResult

@fResult fResult commented Oct 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Create Component
  • Create Histoire component document
    Vote card list in the Assemblies page

VoteCard.story.svelte file - Passed result
VoteCard.story.svelte file - Failed result
VoteCard.story.svelte file - Candidate result

@fResult
fResult force-pushed the fResult/5-vote-card branch from 52efa41 to 8f911a6 Compare October 6, 2023 19:32
@fResult
fResult marked this pull request as ready for review October 6, 2023 19:33
@fResult fResult changed the title WIP VoteCard Component #5 VoteCard Component #5 Oct 6, 2023
@fResult fResult changed the title VoteCard Component #5 VoteCard Component Oct 6, 2023
@fResult fResult changed the title VoteCard Component WIP: VoteCard Component Oct 6, 2023
@fResult
fResult force-pushed the fResult/5-vote-card branch from 8f911a6 to 7ce69bc Compare October 6, 2023 20:23
@fResult
fResult force-pushed the fResult/5-vote-card branch from 7ce69bc to e9f4a6d Compare October 6, 2023 20:27
@fResult fResult changed the title WIP: VoteCard Component VoteCard Component Oct 7, 2023
@fResult fResult mentioned this pull request Oct 7, 2023
Closed
@fResult fResult changed the title VoteCard Component fResult/#5VoteCard Component Oct 7, 2023
@fResult fResult changed the title fResult/#5VoteCard Component fResult/#5 VoteCard Component Oct 7, 2023
@fResult
fResult force-pushed the fResult/5-vote-card branch from ee77002 to 978de69 Compare October 7, 2023 12:51
@fResult
fResult force-pushed the fResult/5-vote-card branch from 978de69 to e11c7e9 Compare October 7, 2023 14:49
@Th1nkK1D
Th1nkK1D self-requested a review October 9, 2023 06:40
Th1nkK1D
Th1nkK1D requested changes Oct 9, 2023
View reviewed changes

@Th1nkK1D Th1nkK1D left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, a very good PR. Thank you so much. Have a few comments and one strange issue on the story. The date is invalid when I choose a custom candidate name from the dropdown. Not sure if you can reproduce it.

image

Comment thread src/components/votes/VoteCard.svelte Outdated
Comment thread src/routes/assemblies/[id]/+page.ts Outdated
Comment thread src/components/votes/VoteCard.svelte Outdated
Comment thread src/routes/assemblies/[id]/+page.svelte Outdated
@fResult

fResult commented Oct 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Overall, a very good PR. Thank you so much. Have a few comments and one strange issue on the story. The date is invalid when I choose a custom candidate name from the dropdown. Not sure if you can reproduce it.

image

I already fixed krub.
But workaround fixing it a bit.
(I cannot find the way to fix it from the root cause) 🥹
Fixed Code
The result that works

@fResult
fResult requested a review from Th1nkK1D October 9, 2023 14:26
Th1nkK1D
Th1nkK1D approved these changes Oct 9, 2023
View reviewed changes

@Th1nkK1D Th1nkK1D left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution. We will contact you back for the stickers at the end of this month.

@Th1nkK1D
Th1nkK1D merged commit ce0da79 into wevisdemo:main Oct 9, 2023
@fResult fResult mentioned this pull request Oct 14, 2023
Merged
@Th1nkK1D

Th1nkK1D commented Nov 3, 2023

Copy link
Copy Markdown
Contributor

Thank you for the Hacktoberfest participation! Please fill up the form before 6 November 2023 to receive our limited-edition stickers.

svnnynior pushed a commit to svnnynior/parliament-watch that referenced this pull request Nov 17, 2023
@fResult
feat(wevisdemo#5): add VoteCard Component (wevisdemo#8)
7213306 
* feat(5): create vote card

* feat(wevisdemo#5): add story for VoteCard component

* feat(wevisdemo#5): make VoteCard story component is able to custom candidate name

* feat(wevisdemo#5): use Design Tokens for typography instead of TailwiindCSS utility classes

* feat(wevisdemo#5): fix follow code reviewed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Th1nkK1D Th1nkK1D Th1nkK1D approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fResult @Th1nkK1D