This repository was archived by the owner on May 13, 2024. It is now read-only.
move videoframechecker to separate file and export as module - #239
Merged
Conversation
Contributor
Author
|
I wonder if it makes sense to have an index.js that exposes both and hides the internal src/js/* location... |
moves the videoframechecker to a separate file and allows requiring videoframechecker and ssim as modules. Also adds an index.js for module usage.
KaptenJansson
approved these changes
Sep 8, 2017
KaptenJansson
left a comment
KaptenJansson
left a comment
Contributor
There was a problem hiding this comment.
Thanks for doing this, I really want to modernize TestRTC but there is not enough time atm :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moves the videoframechecker to a separate file and allows requiring
videoframechecker and ssim as modules