chore(docs): minor fixes in the docs - #874
Merged
Merged
Conversation
fixed indentation and corrected spellings
misterdev
suggested changes
Apr 30, 2019
misterdev
left a comment
misterdev
left a comment
Contributor
There was a problem hiding this comment.
Good job! :)
Do you think we need to change the indentation? I'd keep the old one
prettier makes the initial space twice for ul
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
Contributor
Author
|
@misterdev have a look at the new changes. |
misterdev
approved these changes
Apr 30, 2019
ematipico
reviewed
May 1, 2019
ematipico
left a comment
ematipico
left a comment
Contributor
There was a problem hiding this comment.
Are the tabbing changes caused by your IDE or by the lint-staged where we run prettier?
Contributor
Author
|
It's done using prettier (IDE). |
ematipico
approved these changes
May 1, 2019
|
@pranshuchittora Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed indentation and corrected spellings