chore(upgrade): webpack 4.2 and other dependencies - #362
Conversation
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
| "prettier-eslint-cli": "^4.7.1", | ||
| "schema-utils": "^0.4.5", | ||
| "webpack": "^4.1.1", | ||
| "webpack": "^4.2.0", |
There was a problem hiding this comment.
This is something that bugs me. Shouldn't we have ^4.0.0 and that's it? If not, why?
There was a problem hiding this comment.
The cli should have a loose dependency from webpack as far as I understood. The cli uses only some utilities from webpack. So I still have some unclear thoughts about how this relation is inside the cli. Just personal doubts :)
There was a problem hiding this comment.
About loose dependency, I think it depends on the peer dependency which is currently "^4.0.0".
Lines 109 to 111 in 2222f1d
IMO we should keep our project's dependencies up to date to update the lock file since all npm installation would pick from the versions specified in lock file and not the latest version based on ^ (unless you remove the lock file explicitly before npm installations).
The loose dependency should still carry as it's a peer.
|
@dhruvdutt Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ev1stensberg Please review the new changes. |
|
Upgraded |
No description provided.