serial: Fix getSignals() error handling - #26824
Merged
Merged
Conversation
This change fixes error handling for the getSignals() method. It was assumed that the Mojo reply value could be null on error but this was not allowed by serial.mojom. This meant that if a call to GetControlSignals() failed it would trigger a Mojo connection failure rather than only reporting the (potentially recoverable) error. Tests exercising this case on both the renderer and browser process sides have been added. Bug: 1156864 Change-Id: Ife5c953d5f6748c0290fae2f2d53c5415c1faba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580747 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#835293}
wpt-pr-bot
approved these changes
Dec 9, 2020
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
watilde
added a commit
to watilde/node
that referenced
this pull request
Dec 28, 2020
watilde
added a commit
to nodejs/node
that referenced
this pull request
Jan 1, 2021
Refs: web-platform-tests/wpt#26824 PR-URL: #36659 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
to nodejs/node
that referenced
this pull request
Jan 12, 2021
Refs: web-platform-tests/wpt#26824 PR-URL: #36659 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes error handling for the getSignals() method. It was
assumed that the Mojo reply value could be null on error but this was
not allowed by serial.mojom. This meant that if a call to
GetControlSignals() failed it would trigger a Mojo connection failure
rather than only reporting the (potentially recoverable) error.
Tests exercising this case on both the renderer and browser process
sides have been added.
Bug: 1156864
Change-Id: Ife5c953d5f6748c0290fae2f2d53c5415c1faba6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580747
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835293}