Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR bumps the app to v0.14.5. It adds a new CLAUDE.md documenting “skill guides”; updates release notes with v0.14.5 items (Process Viewer widget, Quake Mode hotkey behavior, Settings bugfixes, drag-and-drop path quoting, opt-in split buttons, widgets sidebar toggle persistence, F2 tab rename, mouse back/forward, COLORTERM=truecolor, terminal clipboard trim, dependency notes); updates Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying waveterm with
|
| Latest commit: |
e02b974
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://58c6fc99.waveterm.pages.dev |
| Branch Preview URL: | https://sawka-onboarding-v0145.waveterm.pages.dev |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
frontend/app/onboarding/onboarding-upgrade-v0145.tsx (1)
16-16: Hide decorative icons from assistive technology.On Lines 16, 29, and 42, these icons are visual-only; mark them
aria-hidden(andfocusable="false"for SVG/font-icon compatibility) to reduce screen-reader noise.Proposed tweak
- <i className="text-[24px] text-accent fa-solid fa-list-tree"></i> + <i className="text-[24px] text-accent fa-solid fa-list-tree" aria-hidden="true" focusable="false"></i> ... - <i className="text-[24px] text-accent fa-solid fa-terminal"></i> + <i className="text-[24px] text-accent fa-solid fa-terminal" aria-hidden="true" focusable="false"></i> ... - <i className="text-[24px] text-accent fa-solid fa-wrench"></i> + <i className="text-[24px] text-accent fa-solid fa-wrench" aria-hidden="true" focusable="false"></i>Also applies to: 29-29, 42-42
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@frontend/app/onboarding/onboarding-upgrade-v0145.tsx` at line 16, The three decorative <i> icon elements (e.g., the one with className "text-[24px] text-accent fa-solid fa-list-tree" and the other two similar font-icon <i> instances at the same file) should be hidden from assistive tech: add aria-hidden="true" and focusable="false" attributes to each of those <i> elements in onboarding-upgrade-v0145.tsx so they remain visual-only and do not appear in screen-reader output or keyboard focus order.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/docs/releasenotes.mdx`:
- Line 14: The release note for "Quake Mode" contains a mismatched issue
reference: the link label `[`#3151`]` does not match the URL
`https://github.com/wavetermdev/waveterm/issues/3138`; update either the label
or the URL so both reference the same issue number (e.g., change the label to
`[`#3138`]` or update the URL to `/issues/3151`) in the markdown line containing
`**Quake Mode** - ...
[`#3151`](https://github.com/wavetermdev/waveterm/issues/3138)`.
---
Nitpick comments:
In `@frontend/app/onboarding/onboarding-upgrade-v0145.tsx`:
- Line 16: The three decorative <i> icon elements (e.g., the one with className
"text-[24px] text-accent fa-solid fa-list-tree" and the other two similar
font-icon <i> instances at the same file) should be hidden from assistive tech:
add aria-hidden="true" and focusable="false" attributes to each of those <i>
elements in onboarding-upgrade-v0145.tsx so they remain visual-only and do not
appear in screen-reader output or keyboard focus order.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: db57a5f4-bde0-4667-9519-1670f013d30e
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (5)
CLAUDE.mddocs/docs/releasenotes.mdxfrontend/app/onboarding/onboarding-common.tsxfrontend/app/onboarding/onboarding-upgrade-patch.tsxfrontend/app/onboarding/onboarding-upgrade-v0145.tsx
| Wave v0.14.5 introduces a new Process Viewer widget, Quake Mode for global hotkey, and several quality-of-life improvements. | ||
|
|
||
| - **Process Viewer** - New widget that displays running processes on local and remote machines, with CPU and memory usage, sortable columns, and the ability to send signals to processes | ||
| - **Quake Mode** - The global hotkey (`app:globalhotkey`) now triggers a dedicated quake mode that drops a Wave window down from the top of the screen, similar to classic quake-style terminals ([#3151](https://github.com/wavetermdev/waveterm/issues/3138)) |
Contributor
There was a problem hiding this comment.
Issue reference text and URL are inconsistent.
On Line 14, the link label shows #3151 but the target URL is issue 3138. Please align both to the same issue number.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/docs/releasenotes.mdx` at line 14, The release note for "Quake Mode"
contains a mismatched issue reference: the link label `[`#3151`]` does not match
the URL `https://github.com/wavetermdev/waveterm/issues/3138`; update either the
label or the URL so both reference the same issue number (e.g., change the label
to `[`#3138`]` or update the URL to `/issues/3151`) in the markdown line
containing `**Quake Mode** - ...
[`#3151`](https://github.com/wavetermdev/waveterm/issues/3138)`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.