fix connstatus in new processviewer widget#3222
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe PR adds connection-status guards in the ProcessViewer view model to skip process-list and keepalive RPCs when disconnected, and updates the ProcessViewer React component to read Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@frontend/app/view/processviewer/processviewer.tsx`:
- Around line 156-160: The paused keepalive path still sends RPCs when offline;
add the same connection check used above to early-return in doKeepAlive() (or
wherever paused keepalive is triggered) by fetching connStatus via
globalStore.get(this.connStatus) and verifying connStatus?.connected before
firing RemoteProcessListCommand; if not connected, skip scheduling/sending the
RemoteProcessListCommand and any related RPC traffic.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 2aee4847-6630-486a-9a54-a14854c8ef37
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (2)
frontend/app/view/processviewer/processviewer.tsxgo.mod
💤 Files with no reviewable changes (1)
- go.mod
No description provided.