Skip to content

fix connstatus in new processviewer widget#3222

Merged
sawka merged 2 commits intomainfrom
sawka/pv-checkconnstatus
Apr 15, 2026
Merged

fix connstatus in new processviewer widget#3222
sawka merged 2 commits intomainfrom
sawka/pv-checkconnstatus

Conversation

@sawka
Copy link
Copy Markdown
Member

@sawka sawka commented Apr 15, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 15, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: f10cdaab-2228-4c62-af47-0aab0fa54b6f

📥 Commits

Reviewing files that changed from the base of the PR and between 2b2ac47 and 7f7329b.

📒 Files selected for processing (1)
  • frontend/app/view/processviewer/processviewer.tsx

Walkthrough

The PR adds connection-status guards in the ProcessViewer view model to skip process-list and keepalive RPCs when disconnected, and updates the ProcessViewer React component to read connStatus and show a centered "Waiting for connection…" placeholder while disconnected (rendering the existing header and virtualized rows only when connected). Separately, go.mod was edited to remove the top-level github.com/sashabaranov/go-openai require entry.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess relevance to the changeset. Add a pull request description explaining the purpose of the connection status fix and why it was needed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title directly relates to the main change: fixing connection status handling in the process viewer widget by adding connection-status gating to prevent RPC calls when disconnected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sawka/pv-checkconnstatus

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Apr 15, 2026

Deploying waveterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7f7329b
Status:⚡️  Build in progress...

View logs

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@frontend/app/view/processviewer/processviewer.tsx`:
- Around line 156-160: The paused keepalive path still sends RPCs when offline;
add the same connection check used above to early-return in doKeepAlive() (or
wherever paused keepalive is triggered) by fetching connStatus via
globalStore.get(this.connStatus) and verifying connStatus?.connected before
firing RemoteProcessListCommand; if not connected, skip scheduling/sending the
RemoteProcessListCommand and any related RPC traffic.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2aee4847-6630-486a-9a54-a14854c8ef37

📥 Commits

Reviewing files that changed from the base of the PR and between 5e3673c and 2b2ac47.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • frontend/app/view/processviewer/processviewer.tsx
  • go.mod
💤 Files with no reviewable changes (1)
  • go.mod

Comment thread frontend/app/view/processviewer/processviewer.tsx
@sawka sawka merged commit 5d0e8e3 into main Apr 15, 2026
6 of 8 checks passed
@sawka sawka deleted the sawka/pv-checkconnstatus branch April 15, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant