Skip to content

feat: add widgets sidebar toggle button to view menu #3140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sawka merged 5 commits into from
Mar 31, 2026
Merged

feat: add widgets sidebar toggle button to view menu #3140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
337ca7f
feat: add widgets sidebar toggle button to tabbar
mswiszcz Mar 27, 2026
2899d98
fix: use derived atom for widgets sidebar visibility to prevent works…
mswiszcz Mar 27, 2026
7a61e68
Merge branch 'main' into feat/sidebar-toggle
mswiszcz Mar 27, 2026
d15a05a
revert tabbar change, simpllify workspace-layout-model change
sawka Mar 31, 2026
56fb5d8
simple widgets toggle in view menu
sawka Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions emain/emain-menu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,20 @@ function makeViewMenu(
{
role: "togglefullscreen",
},
{ type: "separator" },
{
label: "Toggle Widgets Bar",
click: () => {
fireAndForget(async () => {
const workspaceId = focusedWaveWindow?.workspaceId;
if (!workspaceId) return;
const oref = `workspace:${workspaceId}`;
const meta = await RpcApi.GetMetaCommand(ElectronWshClient, { oref });
const current = meta?.["layout:widgetsvisible"] ?? true;
await RpcApi.SetMetaCommand(ElectronWshClient, { oref, meta: { "layout:widgetsvisible": !current } });
});
},
},
];
}

Expand Down
6 changes: 6 additions & 0 deletions frontend/app/workspace/workspace-layout-model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ class WorkspaceLayoutModel {
private focusTimeoutRef: NodeJS.Timeout | null = null;
private debouncedPersistAIWidth: () => void;
private debouncedPersistVTabWidth: () => void;
widgetsSidebarVisibleAtom: jotai.Atom<boolean>;

private constructor() {
this.aiPanelRef = null;
Expand All @@ -71,6 +72,11 @@ class WorkspaceLayoutModel {
this.vtabWidth = VTabBar_DefaultWidth;
this.vtabVisible = false;
this.panelVisibleAtom = jotai.atom(false);
this.widgetsSidebarVisibleAtom = jotai.atom(
Copy link
Copy Markdown
Contributor

@kilo-code-bot kilo-code-bot Bot Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRITICAL: Missing setter - the derived atom has no write functionality

The widgetsSidebarVisibleAtom is now a derived read-only atom (no getter/setter pair). There is no way to update the value. Compare with how panelVisibleAtom works in this file - it has a setter method setAIPanelVisible() that updates the atom and persists to meta. The widgets sidebar needs similar setter functionality to persist visibility changes to layout:widgetsvisible.

(get) =>
get(getOrefMetaKeyAtom(WOS.makeORef("workspace", this.getWorkspaceId()), "layout:widgetsvisible")) ??
true
);
this.initializeFromMeta();

this.handleWindowResize = this.handleWindowResize.bind(this);
Expand Down
3 changes: 2 additions & 1 deletion frontend/app/workspace/workspace.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ const WorkspaceElem = memo(() => {
const tabBarPosition = useAtomValue(getSettingsKeyAtom("app:tabbar")) ?? "top";
const showLeftTabBar = tabBarPosition === "left";
const aiPanelVisible = useAtomValue(workspaceLayoutModel.panelVisibleAtom);
const widgetsSidebarVisible = useAtomValue(workspaceLayoutModel.widgetsSidebarVisibleAtom);
const windowWidth = window.innerWidth;
const leftGroupInitialPct = workspaceLayoutModel.getLeftGroupInitialPercentage(windowWidth, showLeftTabBar);
const innerVTabInitialPct = workspaceLayoutModel.getInnerVTabInitialPercentage(windowWidth, showLeftTabBar);
Expand Down Expand Up @@ -158,7 +159,7 @@ const WorkspaceElem = memo(() => {
) : (
<div className="flex flex-row h-full">
<TabContent key={tabId} tabId={tabId} noTopPadding={showLeftTabBar && isMacOS()} />
<Widgets />
{widgetsSidebarVisible && <Widgets />}
</div>
)}
</Panel>
Expand Down
1 change: 1 addition & 0 deletions frontend/types/gotypes.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1159,6 +1159,7 @@ declare global {
"bg:bordercolor"?: string;
"bg:activebordercolor"?: string;
"layout:vtabbarwidth"?: number;
"layout:widgetsvisible"?: boolean;
"waveai:panelopen"?: boolean;
"waveai:panelwidth"?: number;
"waveai:model"?: string;
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pkg/waveobj/metaconsts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ const (
MetaKey_BgActiveBorderColor = "bg:activebordercolor"

MetaKey_LayoutVTabBarWidth = "layout:vtabbarwidth"
MetaKey_LayoutWidgetsVisible = "layout:widgetsvisible"

MetaKey_WaveAiPanelOpen = "waveai:panelopen"
MetaKey_WaveAiPanelWidth = "waveai:panelwidth"
Expand Down
3 changes: 2 additions & 1 deletion pkg/waveobj/wtypemeta.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@ type MetaTSType struct {
BgActiveBorderColor string `json:"bg:activebordercolor,omitempty"` // frame:activebordercolor

// for workspace
LayoutVTabBarWidth int `json:"layout:vtabbarwidth,omitempty"`
LayoutVTabBarWidth int `json:"layout:vtabbarwidth,omitempty"`
LayoutWidgetsVisible *bool `json:"layout:widgetsvisible,omitempty"`

// for tabs+waveai
WaveAiPanelOpen bool `json:"waveai:panelopen,omitempty"`
Expand Down