-
-
Notifications
You must be signed in to change notification settings - Fork 928
New Vertical Tab Bar Option #3059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
6cf17da
add app:tabbar into settings
sawka 187c9c6
left tabs working, but needs UI cleanup
sawka 5e3ff22
styling updates
sawka 64bf73f
hover working
sawka 1dac092
update ui
sawka f6dc5cf
Merge remote-tracking branch 'origin/main' into sawka/vtabbar-3
sawka df17a38
remove width prop, fix ellipsis padding
sawka ef0dd32
minor
sawka 7a55a3b
build wsh in parallel
sawka 4f269be
checkpoint, resizeable panel for vtabbar
sawka 8b80a20
fix aipanel border and top-left conditional rounding
sawka 0350a48
more cleanup for left tabs
sawka 91b2144
fixed workspace layout
sawka 147f445
hook up contextmenu to vertical tabs
sawka 1fd0ca9
no shrink, reindent
sawka 99011b1
scroll into view
sawka c3fd5ea
scroll on drag
sawka 2b81a88
fix document focus scroll
sawka f61531d
fix vtabbar width across the workspace. fix add tab button
sawka 9b28cf7
change tab position from context menu
sawka ca8979b
update reservation for traffic lights width on macos tahoe
sawka f895fd9
add doc for vertical tab bar
sawka 9ef05fa
macos fixes for vtabbar / tabbar
sawka 58c4b3d
move more initialization into the try/catch
sawka aa38645
fix nits
sawka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,7 @@ out/ | |
| make/ | ||
| artifacts/ | ||
| mikework/ | ||
| aiplans/ | ||
| manifests/ | ||
| .env | ||
| out | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't size the hidden strip by tab count.
When
noTabsis true, this wrapper still expands totabIds.length * tabWidthRef.current, so left-tab mode can end up with an empty horizontal scroller/drag region on large workspaces. Making the wrapper fill the available space avoids that blank strip.Suggested change
<div className="tabs-wrapper" ref={tabsWrapperRef} style={{ - width: `${tabsWrapperWidth}px`, + width: noTabs ? "100%" : `${tabsWrapperWidth}px`, ...(noTabs ? ({ WebkitAppRegion: "drag" } as React.CSSProperties) : {}), }} >🤖 Prompt for AI Agents