[BUGFIX docs] ensure we publish docs - #6257
Merged
Merged
Conversation
runspired
force-pushed
the
bugfix/docs-publishing
branch
from
July 18, 2019 21:06
7785d8a to
7096c32
Compare
runspired
added a commit
that referenced
this pull request
Jul 18, 2019
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous fix in #6252 didn't work properly with
npmpack which does not runprepublishOnly. Incidentally this means we've not been running ourprepublishOnlyscript with previous releases, andts:precompilewhich it contained does not currently work. #6256 removes this command anyway so I've also gone ahead and removed it here to ensure we build properly.I added the new
.npmignorerules and made sure we do a production build for each individual package. At a glance, it appears that thedata.jsonfile produced in the-ember-datapackage is the only such file and contains the docs from the other packages.cc @sivakumar-kailasam