Add API docs for the HasManyReference - #4642
Merged
Merged
Conversation
pangratz
suggested changes
Nov 17, 2016
| comments: DS.hasMany({ async: true }) | ||
| }); | ||
|
|
||
| var post = store.push({ |
Contributor
There was a problem hiding this comment.
not a valid format for store.push
| comments: DS.hasMany({ async: true }) | ||
| }); | ||
|
|
||
| var post = store.push({ |
Contributor
There was a problem hiding this comment.
not a valid format for store.push
| }; | ||
|
|
||
| /** | ||
| The link Ember Data will use to fetch or reload this belongs-to |
| comments: DS.hasMany({ async: true }) | ||
| }); | ||
|
|
||
| var post = store.push({ |
Contributor
There was a problem hiding this comment.
not a valid format for store.push
| comments: DS.hasMany({ async: true }) | ||
| }); | ||
|
|
||
| var post = store.push({ |
Contributor
There was a problem hiding this comment.
not a valid format for store.push
|
|
||
| var commentsRef = post.hasMany('comments'); | ||
|
|
||
| commentsRef.value() === post.get('comments') |
Contributor
There was a problem hiding this comment.
This code sample is not completely accurate. We should either make the relationship sync, or resolve the post.get("comments") and state that the resolved value is commentsRef.value().
I would prefer the promise version to indicate that references allow you synchronous access to an async relationship.
| comments: DS.hasMany({ async: true }) | ||
| }); | ||
|
|
||
| var post = store.push({ |
Contributor
There was a problem hiding this comment.
not a valid format for store.push
| comments: DS.hasMany({ async: true }) | ||
| }); | ||
|
|
||
| var post = store.push({ |
Contributor
There was a problem hiding this comment.
not a valid format for store.push
| }; | ||
|
|
||
| /** | ||
| The link Ember Data will use to fetch or reload this belongs-to |
| ``` | ||
|
|
||
| @method link | ||
| @return {String} The link Ember Data will use to fetch or reload this belongs-to relationship. |
bmac
force-pushed
the
doc-has-many-reference
branch
from
November 18, 2016 14:26
d5b2d30 to
9cd5541
Compare
locks
reviewed
Nov 18, 2016
|
|
||
| Example | ||
|
|
||
| ```javascript |
Contributor
There was a problem hiding this comment.
Can you split into
```app/models/post.js
```
and
```javascript
```
please?
bmac
force-pushed
the
doc-has-many-reference
branch
from
November 18, 2016 14:39
9cd5541 to
00b664a
Compare
bmac
force-pushed
the
doc-has-many-reference
branch
3 times, most recently
from
November 21, 2016 13:24
6ced946 to
dfa365c
Compare
bmac
force-pushed
the
doc-has-many-reference
branch
from
November 21, 2016 13:27
dfa365c to
ae7e8ab
Compare
Contributor
Author
pangratz
approved these changes
Nov 30, 2016
Contributor
|
Thank much @bmac |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.